Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every app should have a sharable web link #1345

Closed
beastoin opened this issue Nov 18, 2024 · 13 comments · Fixed by #1370
Closed

Every app should have a sharable web link #1345

beastoin opened this issue Nov 18, 2024 · 13 comments · Fixed by #1370
Assignees

Comments

@beastoin
Copy link
Collaborator

beastoin commented Nov 18, 2024

As an app/plugin developer, when i create a new app, i immiedeatly want to share it with my friends to promote it.

In app settings, i want to get a web url (copyable) that i can share in Discord/messages so that people could use my app directly.

idealy if it works for both cases:

  • for people who didn't yet download main omi ai app
  • for people who already downloaded
@mdmohsin7
Copy link
Collaborator

Shareable link: h.omi.me/apps/{app_id}

Makes sense I guess? It's the easiest and fastest

@beastoin
Copy link
Collaborator Author

what about try.omi.me/apps/{app_id} ?

@mdmohsin7
Copy link
Collaborator

That works as well. We should have a fixed domain so that we can setup dynamic links right from the beginning

@beastoin
Copy link
Collaborator Author

@chiemduong97 pls try to solve this ticket

fyi we already have the webpage for an app e.g. https://h.omi.me/apps/conversation-summarizer , code repo: https://github.com/BasedHardware/omi/tree/main/frontend - a NextJS project

@kodjima33
Copy link
Collaborator

Guys this needs to be done faster

@beastoin
Copy link
Collaborator Author

got it bruh. let me.

@chiemduong97 please note the step you are on so that i can help.

@mdmohsin7
Copy link
Collaborator

Lmk if any help is needed. Setting up apple-app-site-association and assetlinks.json files on the web and adding the schemas to open the links on Android and iOS (and also link handling) should be enough I guess for the initial version

@beastoin
Copy link
Collaborator Author

beastoin commented Nov 21, 2024

go ahead and get this ticket done pls sir.

pls note:

  • support domains h.omi.me and try.omi.me
  • only allow /apps/:id for now, so that users can access the webpage when they enter h.omi.me/apps or h.omi.me for example - this should be configurated via the json file (Google applink or apple association json)

@mdmohsin7 ⚡️

@mdmohsin7
Copy link
Collaborator

Alright let me try

@beastoin
Copy link
Collaborator Author

beastoin commented Nov 22, 2024

2/ 'Try it' should navigate user to the app screen or appstore/gplaystore

Image

@beastoin
Copy link
Collaborator Author

beastoin commented Nov 22, 2024

3/ App got crashed when opened from the weblink

link: https://h.omi.me/apps/zapier

Image

@chiemduong97
Copy link
Collaborator

issue on android device
https://stackoverflow.com/questions/58596267/flutter-app-opens-in-another-applicationduplicate-application

@mdmohsin7
Copy link
Collaborator

3/ App got crashed when opened from the weblink

Checked Instabug, this looks like an issue with flutter_background_service
SInternalInconsistencyException: No launch handler registered for task with identifier dev.flutter.background.refresh

@beastoin beastoin moved this from In review to Done in omi TODO Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants