Add keyboard shortcut for default action #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the option to set keyboard shortcut through either text in options page (Firefox only) or through browser "manage keyboard shortcuts".
Shortcut changes in the browser will reflect the text box in options and vice-versa, but it recommended to set it through the browser since you have all those default keybinding checks included.
Only Firefox supports changing keyboard shortcuts dynamically (via commands.update() ), due "security concerns" you have to set it through chrome://extensions/shortcuts in Chrome. However, I kept the text box in, since it works on FF.
There should be no breaking change, but I have tested it on Firefox only.
Type of change
Checklist
README.md