Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut for default action #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aethlas
Copy link

@Aethlas Aethlas commented Sep 14, 2024

Description

Added the option to set keyboard shortcut through either text in options page (Firefox only) or through browser "manage keyboard shortcuts".

Shortcut changes in the browser will reflect the text box in options and vice-versa, but it recommended to set it through the browser since you have all those default keybinding checks included.
Only Firefox supports changing keyboard shortcuts dynamically (via commands.update() ), due "security concerns" you have to set it through chrome://extensions/shortcuts in Chrome. However, I kept the text box in, since it works on FF.

There should be no breaking change, but I have tested it on Firefox only.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code quality:
    • I have performed a self-review of my own code
    • I have commented my code, particularly in hard-to-understand areas
  • Tests:
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
  • Other:
    • I have made corresponding changes to the documentation and/or README.md
    • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant