Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-API napi_remove_wrap is not being handled correctly #82

Open
shial4 opened this issue Mar 5, 2024 · 1 comment
Open

Node-API napi_remove_wrap is not being handled correctly #82

shial4 opened this issue Mar 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@shial4
Copy link
Contributor

shial4 commented Mar 5, 2024

If a finalize callback was associated with the wrapping, it will no longer be called when the JavaScript object becomes garbage-collected.

this is the bit from the Node-API docs that is not being handled correctly, from napi_remove_wrap (https://nodejs.org/api/n-api.html#napi_remove_wrap)

@bghgary
Copy link
Contributor

bghgary commented Mar 5, 2024

This is the case in JSC but we should check Chakra also. It should not be an issue for V8.

@bghgary bghgary added the bug Something isn't working label Mar 5, 2024
@thomlucc thomlucc added this to the Future milestone Mar 5, 2024
@thomlucc thomlucc modified the milestones: Future, 8.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants