Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V8 to the latest version to fix security issues #337

Open
syntheticmagus opened this issue Jul 23, 2020 · 3 comments
Open

Update V8 to the latest version to fix security issues #337

syntheticmagus opened this issue Jul 23, 2020 · 3 comments
Milestone

Comments

@syntheticmagus
Copy link
Contributor

#336 disabled warnings in two files pertaining to V8 in order to enable building with warnings treated as errors. Ideally, we would want to fix these warnings rather than just turn them off, but there are complications in both cases.

  • In js_native_api_v8.cc, that file may also exist in other repositories and for that reason we may wish to be cautious about introducing changes to it.
  • In AppRuntimeV8.cpp, the errors I turned off were coming from files inside the V8 NuGet package, over which we have no direct control whatsoever, so I'm not sure there's a better way for us to handle that situation than to simply turn the errors off.
@bghgary
Copy link
Contributor

bghgary commented Apr 25, 2022

We should take a new version of N-API from the node.js repo before even considering fixing anything here.

@thomlucc thomlucc added Future and removed Future labels Sep 23, 2022
@thomlucc thomlucc added this to the Future milestone Sep 23, 2022
@thomlucc thomlucc removed the Future label Sep 23, 2022
@bghgary bghgary modified the milestones: Future, 8.0 Apr 16, 2024
@bghgary
Copy link
Contributor

bghgary commented Sep 4, 2024

Most likely V8 has already fixed all of these. We just need a newer version.

@bghgary bghgary changed the title Consider fixing V8 warnings Fix V8 warnings Sep 4, 2024
@bghgary bghgary changed the title Fix V8 warnings Update V8 to the latest version to fix security issues Oct 2, 2024
@bghgary
Copy link
Contributor

bghgary commented Oct 2, 2024

See pmed/v8-nuget#34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants