Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link for google maps clustering markers #50

Open
rleal-dev opened this issue May 16, 2016 · 6 comments
Open

Broken link for google maps clustering markers #50

rleal-dev opened this issue May 16, 2016 · 6 comments

Comments

@rleal-dev
Copy link

http://biostall.com/demos/google-maps-v3-api-codeigniter-library/cluster
The above link is broken, and it's getting the following error:

Failed to load resource: the server responded with a status of 404 (Not Found):
http://google-maps-utility-library-v3.googlecode.com/svn/trunk/markerclusterer/src/markerclusterer_compiled.js

A possible solution would be replacing the broken link for this one:
line: 1143
//google-maps-utility-library-v3.googlecode.com/svn/trunk/markerclusterer/src/markerclusterer_compiled.js
To
cdn.rawgit.com/googlemaps/js-marker-clusterer/gh-pages/src/markerclusterer.js

And
line 1852
gridSize: '.$this->clusterGridSize;
To
imagePath: "https://cdn.rawgit.com/googlemaps/js-marker-clusterer/gh-pages/images/m",
gridSize: '.$this->clusterGridSize;

Thanks

@PeterTheOne
Copy link

You don't need to update MARKER_CLUSTER_IMAGE_PATH_, you can just set the imagePath option to the path of the local images.

@rleal-dev
Copy link
Author

OK. but the link "http://google-maps-utility-library-v3.googlecode.com/svn/trunk/markerclusterer/src/markerclusterer_compiled.js" is broken. therefore therefore I changed to "cdn.rawgit.com/googlemaps/js-marker-clusterer/gh-pages/src/markerclusterer.js" and worked perfectly.

@PeterTheOne
Copy link

PeterTheOne commented May 25, 2016

Github is not meant for hosting images, if something changes your code is broken again. You can do this var mc = new MarkerClusterer(map, makers, {imagePath: 'https://www.mydomain.com/images/m'});, with images in the folder images, named m1.png - m5.png from https://github.com/googlemaps/js-marker-clusterer/tree/gh-pages/images . This is how it was meant to be used.

@rleal-dev
Copy link
Author

Understood.
I will create a local directory for the images. What about markerclusterer.js what you suggest , let the GitHub link it?

@PeterTheOne
Copy link

You can let the github link, I hope it will also be updated in the markerclusterer.js repository.

@rleal-dev
Copy link
Author

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants