-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAMP Docs Update Failures due to Outdated Node.js Version #826
Comments
We shall review this @MattMatt27 |
@MattMatt27 This needs to be done across all repositories, including LAMP-server, LAMP-js, LAMP-worker, LAMP-dashboard, and LAMP-activities (for all activities). It will be a time-consuming process, and we need to thoroughly test each functionality after making the changes. We shall look into this. |
@sarithapillai8 Would it be possible to prioritize this issue? Currently, we are unable to update our documentation for mindLAMP due to this problem with Node.js. |
@kijote0 sure we will start on this on a priority. |
@MattMatt27 There are some other errors with the build. Could you please let us know if we need to fix that or will you check it ?
|
@sarithapillai8 If you are able to fix this, it would be greatly appreciated! I did a quick investigation to see if I could figure out why that might be failing but had no luck. The |
Ok we can check on that @MattMatt27 |
@MattMatt27 Can you check the updates done? The build issues seem to be fixed. |
@sarithapillai8 Unfortunately it looks like the docs are no longer working after this update. I get the following when I go to https://docs.lamp.digital/ |
We need some time to fix this issue. I tried reverting, but that brought back the original issue we started. I'll work to resolve this as soon as possible. |
@MattMatt27 I’ve been working to resolve the issues by creating code from scratch, updating to the latest versions of React and Docusaurus, and copying the documentation files. I've managed to fix many issues, and I can now see the build files on my local system. The site loads with some errors related to the OpenAPI documentation, though I can still navigate between pages after closing the error pop-up. Current versions are React 18, Node 20, and Docusaurus 3.6.0 I'm currently stuck on an issue: "TypeError: The 'from' argument must be of type string. Received undefined." When debugging, I identified that this error might be caused by the openapi.yml file (potentially due to version changes) or by files generated inside the docusaurus-plugin-openapi/api directory. The undefined schema error may also be related to syntax like this in openapi.tml file:
I'm uncertain which reference is causing the issue. Could you take a look and help troubleshoot? Please see the working screenshots below. |
@sarithapillai8 I think in the interest of getting the docs back up as soon as possible, we should perhaps exclude the pages that are causing this error and keep track of the specific pages that are excluded in a comment on this issue so that we can go back and revisit them once we have the docs.lamp.digital back up and running. |
@kijote0 API docs removed and updated. https://docs.lamp.digital - This site is now loading except the API section. We can continue on this to fix that issue. |
@sarithapillai8 Sounds good, thank you! |
@sarithapillai8 When I tried to edit one of the pages in the docs, I received the following error message. |
@kijote0 Could you please let me know if you've incorporated the latest changes I made before updating? |
@sarithapillai8 I believe so, I had modified one specific page of the docs using the "Edit" button and directly committed to the main branch; I made a few commits, but there were all to the same page and just to modify text. Here is the link to the most recent commit I made: b1f1606. |
@kijote0 Updated the build issue. Please have a look. |
Describe the bug
I just tried making a very minor change to LAMP-platform (fix the favicon path) but the gh-release build failed and I am wondering if this is a more serious concern that requires addressing. It looks like a few of the packages are now expecting a Node.js version of 18 and we are still using 16. See build error below.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
gh-release should succeed and changes should be reflected in the documentation
Desktop (please complete the following information):
Additional context
Based on my understanding it seems like the two potential solutions are upgrading our Node.js version to 18. Or adding package specific version dependencies for all failing packages so that they continue to work on Node 16.
The text was updated successfully, but these errors were encountered: