Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is not compatible with LimeSurvey 6.x #1

Open
saschafoerster opened this issue Dec 29, 2023 · 12 comments
Open

Plugin is not compatible with LimeSurvey 6.x #1

saschafoerster opened this issue Dec 29, 2023 · 12 comments

Comments

@saschafoerster
Copy link

Just found your good plugin and wanted to try it out, but it doesn't work with LimeSurvey 6.x.

@cb-ek
Copy link

cb-ek commented Jan 3, 2024

It is possible to install it on version 6 by adding 6.0 to the config.xml file in the zip file.
Authentication is working (I get a token and LimeSurvey creates a session), but I get stuck into infinite loops between the OAuth server and /index.php?r=admin/authentication/sa/login which redirect to OAuth server...
I don't know what's causing the issue since the plugin code looks OK compared to native LDAP and Webserver plugins.

@zufolo441
Copy link

I confirm this bug.

@Shnoulle
Copy link

Shnoulle commented Jul 3, 2024

Seems fixed by @ulysseus-eu
#4

@Shnoulle
Copy link

Shnoulle commented Jul 3, 2024

I test current one with just adding <version>6</version> it works on 6.5.15 (with the fix #5) with default or not as connection.

PHP8.0 for test

@saschafoerster
Copy link
Author

How can I test it in my installation? I am not so experienced in git and merging different branches.

@Shnoulle
Copy link

Shnoulle commented Jul 5, 2024

  1. update https://github.com/BDSU/limesurvey-oauth2/pull/5/files
  2. Add at <version>6</version>
    <version>5.0</version>

Alternative : Get the file : https://github.com/SondagesPro/limesurvey-oauth2/archive/refs/heads/sondagespro.zip
Unzip locally
Use composer intall in the directory https://getcomposer.org/doc/00-intro.md
Move file fia SFTP on your install.

@zufolo441
Copy link

This fix works, but further fixes are needed in order to make it work with PHP 8.2:
/AuthOAuth2/vendor/league/oauth2-client/src/Token/AccessToken.php row 221:
public function jsonSerialize(): mixed
/AuthOAuth2/vendor/league/oauth2-client/src/Tool/QueryBuilderTrait.php row 31:
return http_build_query($params, '', '&', \PHP_QUERY_RFC3986);

@zufolo441
Copy link

zufolo441 commented Jul 21, 2024

I found another problem: when I log out from application, it doesn't log out from OAuth server. In configuration form there isn't logout url field.
If I log out I can't login with another user until I visit the /logout url of my OAuth server.

@Shnoulle
Copy link

@zufolo441 i use this one now : https://github.com/SondagesPro/limesurvey-oauth2

There are no logout settings if I don't make error ?

@zufolo441
Copy link

no, there aren't, but in my opinion are needed.
I tried your plugin, but I'm not able to activate it. I obtain this error:
500: Errore interno del server - Missing configuration file for plugin AuthOAuth2, looked in "AuthOAuth2/config.xml", inside the folder related to "user" plugin type.

I added config section in config.php, in array "config"

@zufolo441
Copy link

Once removed and re-added folder it started working. Thanks, it has been improved a lot!

@zufolo441
Copy link

Maybe, now, could be really useful map keycloak roles over LS roles...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants