Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change infer radius to not have a preferred infer method #135

Open
SherelynA opened this issue Nov 15, 2024 · 2 comments
Open

Change infer radius to not have a preferred infer method #135

SherelynA opened this issue Nov 15, 2024 · 2 comments

Comments

@SherelynA
Copy link
Collaborator

Currently, the infer_radius has a preference for determining it from the lbol, but it should be what it was before of None. So, there is not preference and the user can choose. Trying to run an sed, and testing out the new version, and it immediately gives me a radius based on the lbol and not the evo models like I would prefer.
Screenshot 2024-11-14 at 11 20 33 PM

@hover2pi
Copy link
Member

hover2pi commented Nov 15, 2024

Are you saying the default is not what you would prefer? Or is setting the infer_from keyword not changing it from the default method?

@SherelynA
Copy link
Collaborator Author

@hover2pi Mmm, while it is not what I prefer, the issues I am having is that at the beginning of the sed I provide an evo model, yet it still provides the infer radius from lbol when I run .results or make_sed(), and I have to then run infer_radius(from='evo_model') and then run .results or make_sed() again to make sure I get the teff based on the evo model radius and not the lbol inferred radius. I don't know it just seemed a bit backward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants