Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests on CI #110

Closed
kelle opened this issue Sep 20, 2024 · 4 comments
Closed

Fix tests on CI #110

kelle opened this issue Sep 20, 2024 · 4 comments

Comments

@kelle
Copy link
Member

kelle commented Sep 20, 2024

I thought I had got the tests running on GitHub Actions but now they aren't working. Something is probably wrong in the .toml file. :/
@kelle kelle mentioned this issue Sep 20, 2024
Closed
@kelle
Copy link
Member Author

kelle commented Sep 20, 2024

It looks like I got tests running in #99 but they broke again in #101

@hover2pi
Copy link
Member

The .toml file was missing the importlib_resources dep. I have a PR I'm working on now where I included it as well as fixes for the test failures.

@kelle
Copy link
Member Author

kelle commented Sep 20, 2024

Oh right, I did know that. Thanks for working on this!

@kelle
Copy link
Member Author

kelle commented Sep 20, 2024

Closed by #111

@kelle kelle closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hover2pi @kelle