Interface graduation management #1355
Conversation
…gement javascript
…off by 1 year (If a student graduted in 2022, then they will only show up if u click 2023)
…BCStudentSoftwareDevTeam/celts into interface-graduation-management
specific year for bonner cohorts in graduationManagement JavaScript
…BCStudentSoftwareDevTeam/celts into interface-graduation-management
…raduation management page.
…ement.py and removed unneccessary comments and print statements
thealphagurlux
changed the title
|
|
||
|
|
||
| @admin_bp.route('/<username>/hasGraduated/', methods=['POST']) | ||
| def hasGraduated(username): |
There was a problem hiding this comment.
The "has" at the beginning of the function was a bit confusing, because it is an attributing verb. I usually associate it with a check, like "isDead" or "hasDied". Maybe change this use a better helping verb like "setGraduationStatus" or something similar.
| return "Error Updating Graduation Status", 500 | ||
|
|
||
| @admin_bp.route('/<username>/hasNotGraduated/', methods=['POST']) | ||
| def hasNotGraduated(username): |
| return "Error Updating Graduation Status", 500 | ||
|
|
||
| @admin_bp.route("/gradStudentsxls/<filterType>", methods=['GET']) | ||
| def gradsxls(filterType): |
There was a problem hiding this comment.
Maybe make this camelCase to match the rest of the functions.
| </div> | ||
| <div class="btn-group" id = "bongroup"> | ||
| <button type="button" class="btn btn-primary dropdown-toggle bonner-filter" id = "cohortFilter" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" > | ||
| Bonner Cohorts |
There was a problem hiding this comment.
I believe this is the line, or it is near the line responsible for this issue. I thought it was a bit confusing that this made the "academic year" selection drop down default to "Bonner Cohort instead of the current year range.
| $('.alert').alert('close'); | ||
| }; | ||
| console.log("Graduation status updated successfully!"); | ||
| msgFlash("Graduation status updated successfully!", "success"); |
There was a problem hiding this comment.
This makes the flash messages a bit overwhelming if a user was attempting to graduate a lot of students at once. Also, when hitting "Select All" button, the message flashes for every user on the page individually.
| @@ -1,5 +1,7 @@ | |||
| $(document).ready(function() { | |||
|
|
|||
| $('.alert').alert('close');// close excess flash messages from graduation managment | |||
There was a problem hiding this comment.
I was mentioning excess flash messages, and this might be the solution. I did not see it effect the flash notification I was getting.
There was a problem hiding this comment.
Why is this empty file here?
Issue Description
Fixes #1315
The purpose of this issue is to create a page that allows celts admins to mark students as graduated in the data base.
The page should include a way for the user to filter students by searching for individual users, by Bonner Cohort (and what academic year they are associated with), as well as students who are participating in the CCE minor (whether they have completed it or made any progress towards it. ).
Changes
-Added 3 main filters and a search bar to filter out students in the table.
-For Bonner Cohorts a button was added to find all Bonner Students for a specific term.
-Export button has been added to export all students who've been marked as graduated and are visible in the table with the current filters applied.