Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portrait images in large image gallery #10

Open
monahakk opened this issue Apr 23, 2019 · 4 comments
Open

Portrait images in large image gallery #10

monahakk opened this issue Apr 23, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@monahakk
Copy link
Contributor

Is your feature request related to a problem? Please describe.
All images currently show up in landscape format in the large image gallery, whether or not they were saved in a landscape orientation. See http://localhost:1313/harp-traditions-of-ireland/royal-portable-irish-harp/ as an example of the orientation being changed

Describe the solution you'd like
I'd like to be able to display portrait images in a large gallery page (maybe with that orientation attribute you mentioned adding?)

Describe alternatives you've considered
If that isn't possible, I'll just switch all those to narrative pages, but that still won't be a great solution.

@monahakk monahakk added the enhancement New feature or request label Apr 23, 2019
@Otterfan Otterfan added bug Something isn't working and removed enhancement New feature or request labels Apr 29, 2019
@Otterfan
Copy link
Member

I'm going to reclassify this as a bug, because something is definitely broken. Those harp images shouldn't be rotated into landscape.

@Otterfan
Copy link
Member

So this is complicated.

The camera that took the rotated harp pictures store orientation information in their EXIF metadata. This data tells applications what orientation the camera was in when the picture was taken and lets the application displaying the image choose whether to rotate the image or not.

Unfortunately browsers can't agree on what to do with these images. Test the example page in Firefox and it works, because Firefox respects this orientation metadata and rotates the image accordingly.

Chrome doesn't rotate the image, leading to a broken display.

We'll have to figure out a way to strip EXIF metadata from images before we post them.

@Otterfan
Copy link
Member

I just pushed a commit that creates optimized derivative images for thumbnails—reduces their dimensions and removes unnecessary EXIF metadata—and it is stripping the orientation metadata too.

This will at least make images show in the same orientation in Chrome and Firefox.

@monahakk
Copy link
Contributor Author

monahakk commented May 2, 2019

So update on this-- it was showing the wrong orientation with me in Firefox as well, even before you stripped the orientation metadata. Since we decided this only impacts 3 images that were taken with a camera, I cropped all three of them enough that they are now showing up with the correct orientation.

So, the bug is not solved, but the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants