diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index e0ddc7168..302e7dd2a 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -16,5 +16,5 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v2 - - name: Grep for PR number in CHANGELOG.md - run: grep -P '\[[^\]]*#${{github.event.number}}[,\]]' CHANGELOG.md + - name: Grep for PR number in CHANGELOG.rst + run: grep -P '\[[^\]]*#${{github.event.number}}[,\]]' CHANGELOG.rst diff --git a/CHANGELOG.rst b/CHANGELOG.rst index c3c4c44e2..bc8a91c81 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -86,6 +86,8 @@ changes `[#504] `__. - changed the default `pint.Unit` formatting to short notation ``:~`` `[#519] `__. + (the asdf serialization still uses long notation (`[#560] `__)) + fixes ~~~~~ diff --git a/weldx/constants.py b/weldx/constants.py index 12f57edb7..d3cf6106f 100644 --- a/weldx/constants.py +++ b/weldx/constants.py @@ -28,7 +28,7 @@ The quantity class supports lots of physical units and will combine them during mathematical operations. For extended details on working with quantities, please see the -`pint documentation `_ +`pint documentation `_ Examples -------- diff --git a/weldx/geometry.py b/weldx/geometry.py index 868a2e53e..6fbce2217 100644 --- a/weldx/geometry.py +++ b/weldx/geometry.py @@ -2535,7 +2535,8 @@ def _shape_triangles( offset : An offset that will be added to all indices. closed_mesh : - If `True`, the side faces of the geometry will also be triangulated. + If `True`, the front and back faces of the geometry will also be + triangulated. Returns ------- diff --git a/weldx/tags/unit/pint_quantity.py b/weldx/tags/unit/pint_quantity.py index bce736cfd..564589ccf 100644 --- a/weldx/tags/unit/pint_quantity.py +++ b/weldx/tags/unit/pint_quantity.py @@ -57,7 +57,7 @@ class PintUnitConverter(WeldxConverter): def to_yaml_tree(self, obj: pint.Unit, tag: str, ctx) -> str: """Convert to python dict.""" - return f"{obj:~}" # use 'short' formatting for serialization + return f"{obj:.}" # use 'long' (.) formatting for serialization (short = ~) def from_yaml_tree(self, node: str, tag: str, ctx) -> pint.Unit: """Reconstruct from tree."""