Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use AttributeFilter to use newtonsoft only on the scim controllers #80

Open
Tasin5541 opened this issue Feb 17, 2022 · 4 comments

Comments

@Tasin5541
Copy link

Current implementation of the json serialization and de serialization forces user to add newtonsoft to the controllers globally which is a problem if someone tries to integrate the scim endpoints into their application that's using the default text.json library (starting from .net core 3.1) which doesn't support DataContract. In this case adding newtonsoft globally is a big no.

We can use the ActionFilterAttribute Class to ensure the scim endpoints use newtonsoft and the other endpoints keep working as it is.

@Tasin5541
Copy link
Author

I would like to work on this if the maintainers approve

@boscoMW
Copy link
Collaborator

boscoMW commented Feb 24, 2022

I would like to work on this if the maintainers approve

Please go ahead,

@RohitTopkhane
Copy link

Can we get solution without Extension newsoft.json

@Sefriol
Copy link

Sefriol commented May 20, 2024

@RohitTopkhane Doable, but it would require whole Microsoft.SystemForCrossDomainIdentityManagement/Protocol to be modified to use System.Text.Json. There is a lot of OnInitialization / Initialized all over the place which I am unsure how meaningful they are. In addition, there is also a bunch of Json Serialization / Deserialization Factory stuff that I am not so sure about.

Sefriol added a commit to Sefriol/SCIMReferenceCode that referenced this issue May 30, 2024
- Some tweaking required
- Fixes AzureAD#73 AzureAD#80
Sefriol added a commit to Sefriol/SCIMReferenceCode that referenced this issue May 31, 2024
- Some tweaking required
- Fixes AzureAD#73 AzureAD#80
Sefriol added a commit to Sefriol/SCIMReferenceCode that referenced this issue May 31, 2024
Sefriol added a commit to Sefriol/SCIMReferenceCode that referenced this issue May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants