Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Version Update & Manifest file check removal by draft #828

Closed
wants to merge 3 commits into from
Closed

Draft Version Update & Manifest file check removal by draft #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0455d08
Updated draft version to latest version
Jul 31, 2024
cf1698a
Removing --app flag in line with latest draft version
Jul 31, 2024
adbdae1
Removing --app flag & draft manisfest files being present check
Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
},
"aks.drafttool.releaseTag": {
"type": "string",
"default": "v0.0.33",
"default": "v0.0.36",
"title": "Draft repository release tag",
"description": "Release tag for the stable Draft tool release."
},
Expand Down
2 changes: 1 addition & 1 deletion src/commands/utils/draft.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async function getDeploymentFiles(
.join(" ");

const language = "java"; // So it doesn't attempt to autodetect the language
const command = `draft create --language ${language} --deployment-only --deploy-type ${deploymentType} --app testapp ${variableArgs} --destination ${destDir} --dry-run --silent`;
const command = `draft create --language ${language} --deployment-only --deploy-type ${deploymentType} ${variableArgs} --destination ${destDir} --dry-run --silent`;

const execOptions: ShellOptions = {
envPaths: [path.dirname(draftBinaryPath)],
Expand Down
2 changes: 1 addition & 1 deletion src/panels/draft/DraftDeploymentPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ export class DraftDeploymentDataProvider implements PanelDataProvider<"draftDepl
.join(" ");

const language = "java"; // So it doesn't attempt to autodetect the language
const command = `draft create --language ${language} --deployment-only --deploy-type ${args.deploymentSpecType} --app ${args.applicationName} ${variableArgs} --destination .${path.sep}${args.location}`;
const command = `draft create --language ${language} --deployment-only --deploy-type ${args.deploymentSpecType} ${variableArgs} --destination .${path.sep}${args.location} --skip-file-detection`;

const execOptions: ShellOptions = {
workingDir: this.workspaceFolder.uri.fsPath,
Expand Down
Loading