Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX enhancements for Attach ACR to Cluster #748

Merged
merged 8 commits into from
Jun 19, 2024
Merged

UX enhancements for Attach ACR to Cluster #748

merged 8 commits into from
Jun 19, 2024

Conversation

peterbom
Copy link
Contributor

@peterbom peterbom commented Jun 18, 2024 •
edited
Loading

Changes:

  • Rename 'Connect' to 'Attach' for consistency with az CLI and docs
  • For fields that are not yet valid, make them disabled rather than invisible
  • Add some description of the functionality at the top of the webview
  • Add text to buttons for accessibility
  • Change button icons to reflect 'attach'/'detach' terminology
  • Make the 'attach' button primary, since it's the main action for the view
  • Use unabbreviated 'Azure Container Registry' in header
  • Refactor 'inline action' into separate component

image
image
image

@peterbom peterbom self-assigned this Jun 18, 2024
qpetraroia
qpetraroia previously approved these changes Jun 18, 2024
View reviewed changes
@peterbom peterbom merged commit 7a77fe6 into Azure:main Jun 19, 2024
8 checks passed
tejhan pushed a commit to tejhan/vscode-aks-tools that referenced this pull request Dec 4, 2024
@peterbom
UX enhancements for Attach ACR to Cluster (Azure#748)
3941c34 
* rename 'connect' to 'attach'

* Avoid displaying fields that are not loaded

* add blurb

* make not-loaded fields disabled and add text to buttons

* Rename action and buttons

* make 'attach' button primary

* move inline action component to common folder

* use unabbreviated 'Azure Container Registry' in title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivelisseca ivelisseca ivelisseca approved these changes

@qpetraroia qpetraroia qpetraroia approved these changes

@Tatsinnit Tatsinnit Awaiting requested review from Tatsinnit

@hsubramanianaks hsubramanianaks Awaiting requested review from hsubramanianaks

Assignees

@peterbom peterbom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbom @qpetraroia @ivelisseca