From ae82bdd2c3de1b515a4be8c646ab0cc217f08cb4 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Tue, 14 Nov 2023 15:54:02 +0800 Subject: [PATCH 1/4] Fix 202-machine-learning-moderately-secure-existing-VNet --- .../main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf index 8b59d811d..ddfd9bf69 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf @@ -8,7 +8,7 @@ terraform { } azureml = { - source = "registry.terraform.io/Telemaco019/azureml" + source = "registry.terraform.io/orobix/azureml" } } } From 3a9df2fa39fb3a3f651c6b39a0b5c0f8de5c4f47 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Wed, 15 Nov 2023 11:20:32 +0800 Subject: [PATCH 2/4] update code --- .../workspace.tf | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf index 8d7d66c6a..fa9f548f6 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf @@ -21,12 +21,12 @@ resource "azurerm_key_vault" "default" { } resource "azurerm_storage_account" "default" { - name = "st${var.name}${var.environment}" - location = azurerm_resource_group.default.location - resource_group_name = azurerm_resource_group.default.name - account_tier = "Standard" - account_replication_type = "GRS" - allow_nested_items_to_be_public = false + name = "st${var.name}${var.environment}" + location = azurerm_resource_group.default.location + resource_group_name = azurerm_resource_group.default.name + account_tier = "Standard" + account_replication_type = "GRS" + allowPublicNestedItemsName = false network_rules { default_action = "Deny" From 41f7250d44244dc2f9db55ef2027a262fd9410a4 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Wed, 15 Nov 2023 11:22:37 +0800 Subject: [PATCH 3/4] update code --- .../main.tf | 2 +- .../workspace.tf | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf index ddfd9bf69..2bcbe7a8a 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/main.tf @@ -4,7 +4,7 @@ terraform { required_providers { azurerm = { source = "hashicorp/azurerm" - version = "=2.78.0" + version = ">=2.78.0" } azureml = { diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf index fa9f548f6..8d7d66c6a 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf @@ -21,12 +21,12 @@ resource "azurerm_key_vault" "default" { } resource "azurerm_storage_account" "default" { - name = "st${var.name}${var.environment}" - location = azurerm_resource_group.default.location - resource_group_name = azurerm_resource_group.default.name - account_tier = "Standard" - account_replication_type = "GRS" - allowPublicNestedItemsName = false + name = "st${var.name}${var.environment}" + location = azurerm_resource_group.default.location + resource_group_name = azurerm_resource_group.default.name + account_tier = "Standard" + account_replication_type = "GRS" + allow_nested_items_to_be_public = false network_rules { default_action = "Deny" From 82437c77a4429eff9355c5987752453c26a8d293 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Tue, 2 Jan 2024 09:34:16 +0800 Subject: [PATCH 4/4] update code --- .../variables.tf | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/variables.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/variables.tf index 6abe1b18a..315b649a9 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/variables.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/variables.tf @@ -1,6 +1,7 @@ variable "name" { type = string description = "Name of the deployment" + default = "testdeploy" } variable "environment" { @@ -26,29 +27,33 @@ variable "image_build_compute_name" { variable "vnet_resource_group_name" { type = string description = "Name of the resource group for the existing VNet" + default = "testvnetrg" } variable "vnet_name" { type = string description = "Name of the existing VNet" + default = "testvnet" } variable "training_subnet_name" { type = string description = "Name of the existing training subnet" + default = "testtrainingsubnet" } variable "aks_subnet_name" { type = string description = "Name of the existing aks subnet" + default = "testakssubnet" } variable "ml_subnet_name" { type = string description = "Name of the existing ML workspace subnet" + default = "testmlsubnet" } - # Existing private DNS zones variables variable "privatelink_api_azureml_ms_resource_id" { type = string