From 72b3c4c60585c48ec36362349c027e86af5ddcb4 Mon Sep 17 00:00:00 2001
From: Tom Archer <tarcher@microsoft.com>
Date: Sun, 24 Nov 2024 16:38:59 -0800
Subject: [PATCH] combining Windows VM sample and backup sample

---
 quickstart/101-backup-vm/README.md    |  31 ----
 quickstart/101-backup-vm/main.tf      | 229 +++++++++++++++-----------
 quickstart/101-backup-vm/outputs.tf   |  29 ++--
 quickstart/101-backup-vm/variables.tf |  48 +-----
 4 files changed, 147 insertions(+), 190 deletions(-)
 delete mode 100644 quickstart/101-backup-vm/README.md

diff --git a/quickstart/101-backup-vm/README.md b/quickstart/101-backup-vm/README.md
deleted file mode 100644
index 4ddb65051..000000000
--- a/quickstart/101-backup-vm/README.md
+++ /dev/null
@@ -1,31 +0,0 @@
-# Azure VM Backup
-This template deploys an Azure VM and configures it for backup.
-
-## Terraform resource types
-
-- [random_pet](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/pet)
-- [azurerm_resource_group](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/resource_group)
-- [azurerm_virtual_network](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/virtual_network)
-- [azurerm_subnet](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/subnet)
-- [random_string](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/string)
-- [azurerm_network_interface](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/network_interface)
-- [azurerm_virtual_machine](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/virtual_machine)
-- [azurerm_recovery_services_vault](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/recovery_services_vault)
-- [azurerm_backup_policy_vm](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/backup_policy_vm)
-- [azurerm_backup_protected_vm](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/backup_protected_vm)
-
-## Variables
-
-| Name | Description | Default value |
-|-|-|-|
-| `resource_group_name_prefix` | Prefix of the resource group name that's combined with a random ID so name is unique in your Azure subscription. | rg |
-| `resource_group_location` | Location of the resource group. | eastus |
-| `virtual_network_name` | Name of the virtual network resource. | "" |
-| `subnet_name` | Name of the virtual network subnet. | "" |
-| `network_interface_name` | Name of the network interface resource. | "" |
-| `virtual_machine_name` | Name of the virtual machine resource. | "" |
-| `recovery_services_vault_name` | Name of the recovery services vault resource. | "" |
-| `backup_policy_vm_name` | Name of the backup policy VM resource. | "" |
-| `backup_protected_vm_name` | Name of the backup protected VM resource. | "" |
-
-## Example
\ No newline at end of file
diff --git a/quickstart/101-backup-vm/main.tf b/quickstart/101-backup-vm/main.tf
index 64a280fe3..384367bd1 100644
--- a/quickstart/101-backup-vm/main.tf
+++ b/quickstart/101-backup-vm/main.tf
@@ -7,149 +7,186 @@ resource "azurerm_resource_group" "rg" {
   name     = random_pet.rg_name.id
 }
 
-resource "random_string" "azurerm_virtual_network_name" {
-  length  = 13
-  lower   = true
-  numeric = false
-  special = false
-  upper   = false
+resource "random_string" "name" {
+  length      = 12
+  lower       = true
+  upper       = false
+  numeric     = false
+  special     = false
 }
 
-resource "azurerm_virtual_network" "example" {
-  name = coalesce(var.virtual_network_name, "vnet-${random_string.azurerm_virtual_network_name.result}")
+# Create virtual network
+resource "azurerm_virtual_network" "my_terraform_network" {
+  name                = "${random_string.name.id}-vnet"
+  address_space       = ["10.0.0.0/16"]
+  location            = azurerm_resource_group.rg.location
   resource_group_name = azurerm_resource_group.rg.name
-  location = azurerm_resource_group.rg.location
-  address_space = ["10.0.0.0/16"]
 }
 
-resource "random_string" "azurerm_subnet_name" {
-  length  = 13
-  lower   = true
-  numeric = false
-  special = false
-  upper   = false
+# Create subnet
+resource "azurerm_subnet" "my_terraform_subnet" {
+  name                 = "${random_string.name.id}-subnet"
+  resource_group_name  = azurerm_resource_group.rg.name
+  virtual_network_name = azurerm_virtual_network.my_terraform_network.name
+  address_prefixes     = ["10.0.1.0/24"]
 }
 
-resource "azurerm_subnet" "example" {
-  name = coalesce(var.subnet_name, "subnet-${random_string.azurerm_subnet_name.result}")
+# Create public IPs
+resource "azurerm_public_ip" "my_terraform_public_ip" {
+  name                = "${random_string.name.id}-public-ip"
+  location            = azurerm_resource_group.rg.location
   resource_group_name = azurerm_resource_group.rg.name
-  virtual_network_name = azurerm_virtual_network.example.name
-  address_prefix = "10.0.2.0/24"
+  allocation_method   = "Dynamic"
 }
 
-resource "random_string" "azurerm_network_interface_name" {
-  length  = 13
-  lower   = true
-  numeric = false
-  special = false
-  upper   = false
+# Create Network Security Group and rules
+resource "azurerm_network_security_group" "my_terraform_nsg" {
+  name                = "${random_string.name.id}-nsg"
+  location            = azurerm_resource_group.rg.location
+  resource_group_name = azurerm_resource_group.rg.name
+
+  security_rule {
+    name                       = "RDP"
+    priority                   = 1000
+    direction                  = "Inbound"
+    access                     = "Allow"
+    protocol                   = "*"
+    source_port_range          = "*"
+    destination_port_range     = "3389"
+    source_address_prefix      = "*"
+    destination_address_prefix = "*"
+  }
+  security_rule {
+    name                       = "web"
+    priority                   = 1001
+    direction                  = "Inbound"
+    access                     = "Allow"
+    protocol                   = "Tcp"
+    source_port_range          = "*"
+    destination_port_range     = "80"
+    source_address_prefix      = "*"
+    destination_address_prefix = "*"
+  }
 }
 
-resource "azurerm_network_interface" "example" {
-  name = coalesce(var.network_interface_name, "nic-${random_string.azurerm_network_interface_name.result}")
-  location = azurerm_resource_group.rg.location
+# Create network interface
+resource "azurerm_network_interface" "my_terraform_nic" {
+  name                = "${random_string.name.id}-nic"
+  location            = azurerm_resource_group.rg.location
   resource_group_name = azurerm_resource_group.rg.name
 
   ip_configuration {
-    name = "internal"
-    subnet_id = azurerm_subnet.example.id
+    name                          = "my_nic_configuration"
+    subnet_id                     = azurerm_subnet.my_terraform_subnet.id
     private_ip_address_allocation = "Dynamic"
+    public_ip_address_id          = azurerm_public_ip.my_terraform_public_ip.id
   }
 }
 
-resource "random_string" "azurerm_virtual_machine_name" {
-  length  = 13
-  lower   = true
-  numeric = false
-  special = false
-  upper   = false
+# Connect the security group to the network interface
+resource "azurerm_network_interface_security_group_association" "example" {
+  network_interface_id      = azurerm_network_interface.my_terraform_nic.id
+  network_security_group_id = azurerm_network_security_group.my_terraform_nsg.id
 }
 
-resource "azurerm_virtual_machine" "example" {
-  name = coalesce(var.virtual_machine_name, "vm-${random_string.azurerm_virtual_machine_name.result}")
-  location = azurerm_resource_group.rg.location
-  resource_group_name = azurerm_resource_group.rg.name
-  network_interface_id = azurerm_network_interface.example.id
-  vm_size = "Standard_D2s_v3"
-
-  delete_os_disk_on_termination = true
-  delete_data_disks_on_termination = true
+# Create storage account for boot diagnostics
+resource "azurerm_storage_account" "my_storage_account" {
+  name                     = "diag${random_id.random_id.hex}"
+  location                 = azurerm_resource_group.rg.location
+  resource_group_name      = azurerm_resource_group.rg.name
+  account_tier             = "Standard"
+  account_replication_type = "LRS"
+}
 
-  storage_image_reference {
-    publisher = "Canonical"
-    offer = "UbuntuServer"
-    sku = "16.04-LTS"
-    version = "latest"
+# Create virtual machine
+resource "azurerm_windows_virtual_machine" "main" {
+  name                  = "${random_string.name.id}-vm"
+  admin_username        = "azureuser"
+  admin_password        = random_password.password.result
+  location              = azurerm_resource_group.rg.location
+  resource_group_name   = azurerm_resource_group.rg.name
+  network_interface_ids = [azurerm_network_interface.my_terraform_nic.id]
+  size                  = "Standard_DS1_v2"
+
+  os_disk {
+    name                 = "myOsDisk"
+    caching              = "ReadWrite"
+    storage_account_type = "Premium_LRS"
   }
 
-  storage_os_disk {
-    name = "os-disk"
-    caching = "ReadWrite"
-    create_option = "FromImage"
+  source_image_reference {
+    publisher = "MicrosoftWindowsServer"
+    offer     = "WindowsServer"
+    sku       = "2022-datacenter-azure-edition"
+    version   = "latest"
   }
 
-  os_profile {
-    computer_name = "hostname"
-    admin_username = "testadmin"
-    admin_password = "Password1234!"
+
+  boot_diagnostics {
+    storage_account_uri = azurerm_storage_account.my_storage_account.primary_blob_endpoint
   }
+}
+
+# Install IIS web server to the virtual machine
+resource "azurerm_virtual_machine_extension" "web_server_install" {
+  name                       = "${random_string.name.id}-wsi"
+  virtual_machine_id         = azurerm_windows_virtual_machine.main.id
+  publisher                  = "Microsoft.Compute"
+  type                       = "CustomScriptExtension"
+  type_handler_version       = "1.8"
+  auto_upgrade_minor_version = true
+
+  settings = <<SETTINGS
+    {
+      "commandToExecute": "powershell -ExecutionPolicy Unrestricted Install-WindowsFeature -Name Web-Server -IncludeAllSubFeature -IncludeManagementTools"
+    }
+  SETTINGS
+}
 
-  os_profile_linux_config {
-    disable_password_authentication = false
+# Generate random text for a unique storage account name
+resource "random_id" "random_id" {
+  keepers = {
+    # Generate a new ID only when a new resource group is defined
+    resource_group = azurerm_resource_group.rg.name
   }
+
+  byte_length = 8
 }
 
-resource "random_string" "azurerm_recovery_services_vault_name" {
-  length  = 13
-  lower   = true
-  numeric = false
-  special = false
-  upper   = false
+resource "random_password" "password" {
+  length      = 20
+  min_lower   = 1
+  min_upper   = 1
+  min_numeric = 1
+  min_special = 1
+  special     = true
 }
 
 resource "azurerm_recovery_services_vault" "example" {
-  name = coalesce(var.recovery_services_vault_name, "vault-${random_string.azurerm_recovery_services_vault_name.result}")
-  location = azurerm_resource_group.rg.location
+  name                = "${random_string.name.id}-vault"
   resource_group_name = azurerm_resource_group.rg.name
-  sku = "Standard"
-}
-
-resource "random_string" "azurerm_backup_policy_vm_name" {
-  length  = 13
-  lower   = true
-  numeric = false
-  special = false
-  upper   = false
+  location            = azurerm_resource_group.rg.location
+  sku                 = "Standard"
 }
 
 resource "azurerm_backup_policy_vm" "example" {
-  name = coalesce(var.backup_policy_vm_name, "policy-${random_string.azurerm_backup_policy_vm_name.result}")
+  name                = "${random_string.name.id}-policy"
   resource_group_name = azurerm_resource_group.rg.name
   recovery_vault_name = azurerm_recovery_services_vault.example.name
 
-  timezone = "Pacific Standard Time"
-
   backup {
     frequency = "Daily"
-    time = "23:00"
+    time      = "23:00"
   }
 
   retention_daily {
-    count = 10
+    count = 7
   }
 }
 
-resource "random_string" "azurerm_backup_protected_vm_name" {
-  length  = 13
-  lower   = true
-  numeric = false
-  special = false
-  upper   = false
-}
-
 resource "azurerm_backup_protected_vm" "example" {
-  resource_group_name = azurerm_resource_group.rg.name
-  recovery_vault_name = azurerm_recovery_services_vault.example.name
-  source_vm_id = azurerm_virtual_machine.example.id
-  backup_policy_id = azurerm_backup_policy_vm.example.id
-}
\ No newline at end of file
+  resource_group_name     = azurerm_resource_group.rg.name
+  recovery_vault_name     = azurerm_recovery_services_vault.example.name
+  source_vm_id            = azurerm_windows_virtual_machine.main.id
+  backup_policy_id        = azurerm_backup_policy_vm.example.id
+}
diff --git a/quickstart/101-backup-vm/outputs.tf b/quickstart/101-backup-vm/outputs.tf
index 018d70772..bb6b4aa50 100644
--- a/quickstart/101-backup-vm/outputs.tf
+++ b/quickstart/101-backup-vm/outputs.tf
@@ -2,30 +2,23 @@ output "resource_group_name" {
   value = azurerm_resource_group.rg.name
 }
 
-output "virtual_network_name" {
-  value = azurerm_virtual_network.example.name
-}
-
-output "subnet_name" {
-  value = azurerm_subnet.example.name
-}
-
-output "network_interface_name" {
-  value = azurerm_network_interface.example.name
+output "azurerm_recovery_services_vault_name" {
+  value = azurerm_recovery_services_vault.example.name
 }
 
-output "virtual_machine_name" {
-  value = azurerm_virtual_machine.example.name
+output "azurerm_backup_policy_vm_name" {
+  value = azurerm_backup_policy_vm.example.name
 }
 
-output "recovery_services_vault_name" {
-  value = azurerm_recovery_services_vault.example.name
+output "azurerm_windows_virtual_machine_name" {
+  value = azurerm_windows_virtual_machine.main.name
 }
 
-output "backup_policy_vm_name" {
-  value = azurerm_backup_policy_vm.example.name
+output "public_ip_address" {
+  value = azurerm_windows_virtual_machine.main.public_ip_address
 }
 
-output "backup_protected_vm_name" {
-  value = azurerm_backup_protected_vm.example.name
+output "admin_password" {
+  sensitive = true
+  value     = azurerm_windows_virtual_machine.main.admin_password
 }
\ No newline at end of file
diff --git a/quickstart/101-backup-vm/variables.tf b/quickstart/101-backup-vm/variables.tf
index f2bb3dc72..1a8c6abba 100644
--- a/quickstart/101-backup-vm/variables.tf
+++ b/quickstart/101-backup-vm/variables.tf
@@ -1,53 +1,11 @@
-variable "resource_group_name_prefix" {
-  type        = string
-  default     = "rg"
-  description = "Prefix of the resource group name that's combined with a random ID so name is unique in your Azure subscription."
-}
-
 variable "resource_group_location" {
   type        = string
   default     = "eastus"
   description = "Location of the resource group."
 }
 
-variable "virtual_network_name" {
-  type        = string
-  description = "The name of the virtual network resource. The value will be randomly generated if blank."
-  default     = ""
-}
-
-variable "subnet_name" {
-  type        = string
-  description = "The name of the virtual network subnet. The value will be randomly generated if blank."
-  default     = ""
-}
-
-variable "network_interface_name" {
-  type        = string
-  description = "The name of the network interface resource. The value will be randomly generated if blank."
-  default     = ""
-}
-
-variable "virtual_machine_name" {
-  type        = string
-  description = "The name of the virtual machine resource. The value will be randomly generated if blank."
-  default     = ""
-}
-
-variable "recovery_services_vault_name" {
-  type        = string
-  description = "The name of the recovery services vault resource. The value will be randomly generated if blank."
-  default     = ""
-}
-
-variable "backup_policy_vm_name" {
-  type        = string
-  description = "The name of the backup policy VM resource. The value will be randomly generated if blank."
-  default     = ""
-}
-
-variable "backup_protected_vm_name" {
+variable "resource_group_name_prefix" {
   type        = string
-  description = "The name of the backup protected VM resource. The value will be randomly generated if blank."
-  default     = ""
+  default     = "rg"
+  description = "Prefix of the resource group name that's combined with a random ID so name is unique in your Azure subscription."
 }
\ No newline at end of file