Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM script proposal]: Support running pre-commit checks behind a proxy with SSL inspection and a mirrored Docker image #166

Open
1 task done
JamesDLD opened this issue Nov 6, 2024 · 3 comments · May be fixed by #167

Comments

@JamesDLD
Copy link

JamesDLD commented Nov 6, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

(Optional) Module Version

No response

(Optional) Correlation Id

No response

Description

Add optional parameters to support running pre-commit checks behind a proxy with SSL inspection and a mirrored Docker image.

Usage: ./avm <make target> <custom docker run option> <custom docker image>
<make target>: Running all pre-commit checks, could be 'pre-commit' or 'pr-check'.
<custom docker run option>: Docker option when running behind a proxy with SSL inspection for example.
<custom docker image>: Docker source image if you only have access to mirrored images.

Sample 1: Run the pre-commit check 'pre-commit' that runs depsensure fmt fumpt autofix docs
./avm pre-commit

Sample 2: Run the pre-commit check 'pr-check' that fmtcheck tfvalidatecheck lint unit-test
./avm pr-check

Sample 3: Run the pre-commit check 'pr-commit' behind a proxy with SSL inspection and a mirrored Docker image
./avm pr-commit\ 
'--add-host proxylocal:192.168.xx.x -e HTTPS_PROXY -e HTTP_PROXY -e https_proxy -e http_proxy -e no_proxy -v /etc/ssl/certs/ca-certificates.crt:/etc/pki/tls/certs/ca-bundle.trust.crt' \ 
'registry-docker.myinternaldomain.com/vendors/azterraform:latest'

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants