[AVM Question/Feedback]: template does not respect TFNFR1

[zioproto]

Check for previous/existing GitHub issues

• I have checked for previous/existing GitHub issues

Description

I was checking TFNFR1

https://azure.github.io/Azure-Verified-Modules/specs/terraform/#id-tfnfr1---category-documentation---descriptions

And I believe the customer_managed_key variable in the template does not respect TFNFR1

terraform-azurerm-avm-template/variables.tf

Lines 19 to 31 in fa17004

	# required AVM interfaces
	# remove only if not supported by the resource
	# tflint-ignore: terraform_unused_declarations
	variable "customer_managed_key" {
	type = object({
	key_vault_resource_id = optional(string)
	key_name = optional(string)
	key_version = optional(string, null)
	user_assigned_identity_resource_id = optional(string, null)
	})
	default = {}
	description = "Customer managed keys that should be associated with the resource."
	}

[zioproto]

Also lock is missing the example in the description:

terraform-azurerm-avm-template/variables.tf

Lines 94 to 107 in fa17004

	variable "lock" {
	type = object({
	name = optional(string, null)
	kind = optional(string, "None")
	})
	default = {}
	description = "The lock level to apply. Default is `None`. Possible values are `None`, `CanNotDelete`, and `ReadOnly`."
	nullable = false
	validation {
	condition = contains(["CanNotDelete", "ReadOnly", "None"], var.lock.kind)
	error_message = "The lock level must be one of: 'None', 'CanNotDelete', or 'ReadOnly'."
	}
	}

[prjelesi]

@matt-FFFFFF

[matt-FFFFFF]

I think the NFR needs changing to MAY