Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between namespaces and env variable usage #122

Open
swgriffith opened this issue Oct 24, 2019 · 2 comments
Open

Inconsistency between namespaces and env variable usage #122

swgriffith opened this issue Oct 24, 2019 · 2 comments

Comments

@swgriffith
Copy link
Member

Just putting this out there for discussion. The charts set the namespace to default, but the environment variables for the api fqdns all assume 'hackfest'. It's not an issue for people following the lab exactly because our helm commands set the namespace to hackfest, but it's a bit inconsistent, and anyone messing with the namespace will hit issues where the service tracker UI cant hit the backend services.

Does it make sense to just swap out the 'default' everywhere with hackfest, or parameterize the namespace to give people more flexibility to play with the namespace?

@jschluchter
Copy link
Member

Feel free to change at your own discretion. LMK if you have access to do so.

@jschluchter
Copy link
Member

@swgriffith this is fixed, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants