Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 4.2.0 adds support for FCM v1...but no way to call SendFcmv1NativeNotificationAsync since it's missing from the INotificationHubClient interface #307

Open
3 tasks done
awaldow opened this issue Mar 4, 2024 · 4 comments · May be fixed by #311
Open
3 tasks done

[BUG] 4.2.0 adds support for FCM v1...but no way to call SendFcmv1NativeNotificationAsync since it's missing from the INotificationHubClient interface #307

awaldow opened this issue Mar 4, 2024 · 4 comments · May be fixed by #311

Comments

@awaldow
Copy link

awaldow commented Mar 4, 2024

Describe the bug
Seems like Send... support for FCMv1 is missing from the interface - it has endpoints defined in the client impl itself but not the INotificationHubClient

https://github.com/Azure/azure-notificationhubs-dotnet/blob/main/src/Microsoft.Azure.NotificationHubs/INotificationHubClient.cs#L1408 shows the interface, absent the methods.

https://github.com/Azure/azure-notificationhubs-dotnet/blob/main/src/Microsoft.Azure.NotificationHubs/NotificationHubClient.cs#L639 shows the client having the desired methods.

Exception or Stack Trace

To Reproduce

Steps to reproduce the behavior:

  1. Install 4.2.0
  2. Notice you can't call SendFcmV1NativeNotificationAsync

Code Snippet

Expected behavior
The underlying client impl methods are exposed on the interface.

Screenshots
If applicable, add screenshots to help explain your problem.

Setup (please complete the following information):

  • OS: Windows 10
  • IDE : Visual Studio 2022,VS Code,
  • 4.2.0

Additional context
Add any other context about the problem here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@rextor92 rextor92 linked a pull request Mar 22, 2024 that will close this issue
Open
7 tasks
@OculiViridi
Copy link

Is this issue solved?

@awaldow
Copy link
Author

awaldow commented May 23, 2024 •
edited
Loading

No, you can get around it by passing an FcmV1Notification to SendNotificationAsync though. There's just no first party method like the other platforms yet as far as I can see.

Edit: looks like there's a draft PR around this so we'll have to wait for that to get in.

@Buyani
Copy link

Buyani commented Jun 4, 2024

How should a payload for "SendFcmV1NativeNotificationAsync" look like to cross platform or native android or iOS?

@awaldow
Copy link
Author

awaldow commented Jun 4, 2024

You would probably want to refer to the Firebase docs on payload formatting for FCMv1, since there were some changes in the shape of the message required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/fcmv1 rextor92/azure-notificationhubs-dotnet
3 participants
@awaldow @Buyani @OculiViridi