-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make browser push available #324
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
not yet approved? |
Do you have a work example sending notification to browser? |
Is this supposed to work?
|
Same error on my side ... @microsoft : do your f*** job ! |
I posted a question on Stack Overflow and got an answer: https://stackoverflow.com/q/79010204/1737091 I already gave up and wrote my own alternative to Notification Hubs, so I didn't try it, but maybe you can find it helpful! |
About "Error: The JSON value could not be converted to Microsoft.NotificationHubs.Contracts.LegacyModels.BrowserPushSubscription.": This can be fixed by changing the type of PushChannel from string to object in Installation.cs and directly assign the BrowserPushSubscription to the PushChannel property in BrowserInstallation.cs. See https://github.com/kwaclaw/azure-notificationhubs-dotnet |
Things to consider before you submit the PR:
Description
DataContractSerializer
forBrowserRegistrationDescription
.BrowserRegistrationDescription
asKnownType
.BrowserNotification
's constructor to support pushing direct notifications.Related PRs or issues
Closes #305, closes #314
Misc
If anyone wants to preview the changes, this nuget package is available.