Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebApp SSL binding bug #45

Open
hovsepm opened this issue Oct 11, 2017 · 2 comments
Open

WebApp SSL binding bug #45

hovsepm opened this issue Oct 11, 2017 · 2 comments

Comments

@hovsepm
Copy link
Contributor

hovsepm commented Oct 11, 2017

From @j055 on August 31, 2017 14:2

#2935 - No update since June but this is still an issue in the latest release v1.2.

I've tested in a new web app with certificate installed. The certificate binding is not added.

           _webApp.Update()
                .WithClientCertEnabled(true)
                .DefineHostnameBinding()
                .WithThirdPartyDomain(domain)
                .WithSubDomain(subDomain)
                .WithDnsRecordType(CustomHostNameDnsRecordType.CName)
                .Attach()
                .Apply();

The API doesn't allow specifying IP or SNI and I have no idea why WithClientCertEnabled(true) is stuck there.

A better way might be:

            _webApp.Update()
                .DefineSslBinding()
                .ForHostname(domain)
                .WithExistingCertificate(thumbprint)
                .WithSniBasedSsl()
                .Attach()
                .Apply();

Thanks
Andrew

Copied from original issue: Azure/azure-sdk-for-net#3643

@martinsawicki
Copy link
Contributor

it looks like we missed porting .withExistingCertificate() on the Update chain to .NET...
we'll try to squeeze it into v1.4

@hovsepm hovsepm modified the milestones: v1.4, v1.8 Mar 1, 2018
@hovsepm hovsepm modified the milestones: v1.8, v1.9 Mar 27, 2018
@hovsepm hovsepm modified the milestones: v1.9, v1.10 Apr 16, 2018
@hovsepm hovsepm modified the milestones: v1.10, Backlog May 8, 2018
@yaohaizh
Copy link

@xccc-smft, @ChenTanyi , do you know whether we fix this issue recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants