AB#30275542 Hide stack settings for logic app (#7912)

* disable stack settings version update for logic app * update stack error string * update siterouter * hide stack settings for logic app * use a scenario instead * remove unused imports --------- Co-authored-by: Qi Liu <[email protected]>
Azure · Nov 19, 2024 · 003c517 · 003c517
1 parent e71aa52
commit 003c517
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/client-react/src/pages/app/app-settings/Sections/GeneralSettings.tsx b/client-react/src/pages/app/app-settings/Sections/GeneralSettings.tsx
@@ -32,15 +32,18 @@ const GeneralSettings: React.FC<FormikProps<AppSettingsFormValues>> = props => {
     return null;
   };
 
-  const isSiteContainer = useMemo(() => {
-    return values.config?.properties.linuxFxVersion
+  const showStack = useMemo(() => {
+    const isSiteContainer = values.config?.properties.linuxFxVersion
       ? StringUtils.equalsIgnoreCase(values.config?.properties.linuxFxVersion, DeploymentCenterConstants.sitecontainers)
       : false;
-  }, [values.config?.properties.linuxFxVersion]);
+    const showStackSettingStatus = scenarioChecker.checkScenario(ScenarioIds.showStackSettings, { site }).status;
+
+    return !isSiteContainer && showStackSettingStatus !== 'disabled';
+  }, [values.config?.properties.linuxFxVersion, site]);
 
   return (
     <>
-      {!isSiteContainer && <Stacks {...props} />}
+      {showStack && <Stacks {...props} />}
       {/* NOTE (krmitta): Need to hide platform settings except TLS settings for KubeApp as elements within are not shown */}
       <>
         <h3>{t('platformSettings')}</h3>

diff --git a/client-react/src/utils/scenario-checker/scenario-ids.ts b/client-react/src/utils/scenario-checker/scenario-ids.ts
@@ -106,6 +106,7 @@ export class ScenarioIds {
   public static readonly xenonAppRuntimeStack = 'xenonAppRuntimeStack';
   public static readonly showAppInsightsLogs = 'showAppInsightsLogs';
   public static readonly showRuntimeVersionSetting = 'showRuntimeVersionSetting';
+  public static readonly showStackSettings = 'showStackSettings';
   public static readonly deploymentCenterLogs = 'deploymentCenterLogs';
   public static readonly kuduBuildProvider = 'kuduBuildProvider';
   public static readonly dockerCompose = 'dockerCompose';

diff --git a/client-react/src/utils/scenario-checker/workflow-app.environment.ts b/client-react/src/utils/scenario-checker/workflow-app.environment.ts
@@ -22,6 +22,13 @@ export class WorkflowAppEnvironment extends FunctionAppEnvironment {
       },
     };
 
+    this.scenarioChecks[ScenarioIds.showStackSettings] = {
+      id: ScenarioIds.showStackSettings,
+      runCheck: () => {
+        return { status: 'disabled' };
+      },
+    };
+
     this.scenarioChecks[ScenarioIds.enableCustomErrorPages] = {
       id: ScenarioIds.enableCustomErrorPages,
       runCheck: () => {