New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] naming breaking when migrate swagger to typespec #2979

Open

msyyc opened this issue Dec 23, 2024 · 1 comment

Assignees

Labels

bug

Member

msyyc commented Dec 23, 2024 •

edited

Loading

When signature name begins with $ like https://github.com/Azure/azure-rest-api-specs/blob/d1d028736d79183a6a420e29145887fb02d1b1a9/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-07-01/virtualMachineExtensionImage.json#L120-L124

Then the generated signature name in SDK is:

However, when migrate it to typespec

https://github.com/Azure/azure-rest-api-specs/blob/d1d028736d79183a6a420e29145887fb02d1b1a9/specification/compute/Compute.Management/VirtualMachineExtensionImage.tsp#L79-L80

the signature name is changed to _filter which has breakings compared with before:

The text was updated successfully, but these errors were encountered:

msyyc added the bug label

msyyc self-assigned this

Member Author

msyyc commented Dec 23, 2024

We need to optimize the logic that converts camel case to snake case: https://github.com/microsoft/typespec/blob/477560b2be680a4fd52bbe769fd5341e7b5715f8/packages/http-client-python/emitter/src/utils.ts#L91-L97

msyyc mentioned this issue

Compare python SDK for compute TypeSpec migration Azure/azure-sdk-for-python#38620

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment