New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mgmt mypy issue client should be annotated #2972

Open

lmazuel opened this issue Dec 17, 2024 · 0 comments

Assignees

Member

lmazuel commented Dec 17, 2024

In particular:

azure/mgmt/keyvault/aio/_key_vault_management_client.py:98: error: Need type annotation for "_client" [var-annotated]

That's this line:
https://github.com/Azure/azure-sdk-for-python/blob/897f81deb3bbefc15db8608293863e0628d8d5a4/sdk/keyvault/azure-mgmt-keyvault/azure/mgmt/keyvault/_key_vault_management_client.py#L98

I tested the fix successfully:

self._client : ARMPipelineClient = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
...
self._client : AsyncARMPipelineClient = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)

While I know we're giving up on multi-api, given the simplicity of that fix, I though we could do it, and get mypy happier for customers.

msyyc self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment