Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM] NestedObject flatten #47

Open
ArcturusZhang opened this issue Nov 4, 2019 · 1 comment
Open

[MM] NestedObject flatten #47

ArcturusZhang opened this issue Nov 4, 2019 · 1 comment

Comments

@ArcturusZhang
Copy link
Member

If a NestedObject only contains one field, the reviewers from terraform would require us to flatten the structure. For example, on behalf of cli, we have an api.yml saying

      - !ruby/object:Api::Type::NestedObject
        name: 'identity'
        description: ''
        required: false
        azure_sdk_references: ['/identity']
        properties:
          - !ruby/object:Api::Type::Enum
            name: 'type'
            description: 'The type of Managed Identity used by the DiskEncryptionSet. Only SystemAssigned is supported.'
            required: false
            azure_sdk_references: ['/identity/type']
            values:
              - :SystemAssigned
            default_value: :SystemAssigned

This should be replaced by

      - !ruby/object:Api::Type::Enum
        name: 'identityType'
        description: 'The type of Managed Identity used by the DiskEncryptionSet. Only SystemAssigned is supported.'
        required: false
        azure_sdk_references: ['/identity/type']
        values:
          - :SystemAssigned
        default_value: :SystemAssigned

This issue was initially filed to MM here

@zikalino
Copy link

this can be fixed already.
if you add:
flatten-all: true
to readme.cli.md file it will flatten everything by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants