From 1be5186eb86112312c6eee114fc16937edd99e3a Mon Sep 17 00:00:00 2001 From: Koshy John Date: Tue, 27 Feb 2024 16:39:01 -0800 Subject: [PATCH 1/7] Remove external dependencies from coverage --- .github/codecov.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/codecov.yml b/.github/codecov.yml index 9c4549fb..0975040c 100644 --- a/.github/codecov.yml +++ b/.github/codecov.yml @@ -4,6 +4,8 @@ comment: require_changes: false github_checks: annotations: false +ignore: + - "src/core/src/external_dependencies" coverage: precision: 2 round: down @@ -11,7 +13,7 @@ coverage: status: project: default: - target: 75% + target: 90% threshold: 0% if_ci_failed: error if_not_found: failure @@ -26,4 +28,4 @@ coverage: target: 100% threshold: 0% if_ci_failed: error - if_not_found: failure \ No newline at end of file + if_not_found: failure From 9193d0289ad8542585e56ac2188142bd3dd94f7c Mon Sep 17 00:00:00 2001 From: Koshy John Date: Tue, 27 Feb 2024 16:48:36 -0800 Subject: [PATCH 2/7] Retry path specification --- .github/codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/codecov.yml b/.github/codecov.yml index 0975040c..7894505a 100644 --- a/.github/codecov.yml +++ b/.github/codecov.yml @@ -5,7 +5,7 @@ comment: github_checks: annotations: false ignore: - - "src/core/src/external_dependencies" + - "**/external_dependencies/*.py" coverage: precision: 2 round: down From 650441d7834eadb5fbfb0055a91320322ca0112a Mon Sep 17 00:00:00 2001 From: Koshy John Date: Wed, 28 Feb 2024 10:36:23 -0800 Subject: [PATCH 3/7] Update ci.yml Reviewing what happens with dependencies --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 94a0bb90..fb2c0bd9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,6 @@ jobs: fi codecov-python-27: runs-on: windows-latest - needs: codecov-python-39 steps: - name: Checkout uses: actions/checkout@v4 From ab43fc583bb54945339e134cb9d82de8468f73f9 Mon Sep 17 00:00:00 2001 From: Koshy John Date: Wed, 28 Feb 2024 10:36:54 -0800 Subject: [PATCH 4/7] Update codecov.yml Experimenting --- .github/codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/codecov.yml b/.github/codecov.yml index 7894505a..e389f431 100644 --- a/.github/codecov.yml +++ b/.github/codecov.yml @@ -5,7 +5,7 @@ comment: github_checks: annotations: false ignore: - - "**/external_dependencies/*.py" + - "distro.py" coverage: precision: 2 round: down From eab7b3ad76221f531d89a1498218dbcec85724d2 Mon Sep 17 00:00:00 2001 From: Koshy John Date: Thu, 21 Mar 2024 08:57:57 -0700 Subject: [PATCH 5/7] Including contributing.md --- CONTRIBUTING.md | 50 ++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 39 insertions(+), 11 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7b73616e..617ed650 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,6 +12,7 @@ If you would like to become an active contributor to this project, please follow [Making Changes](#making-changes) - [Pull Requests](#pull-requests) - [Pull Request Guidelines](#pull-request-guidelines) + - [PR Planning / AzGPS Engineering Requirements](#pr-planning--azgps-engineering-requirements) - [Cleaning up commits](#cleaning-up-commits) - [General guidelines](#general-guidelines) - [Testing guidelines](#testing-guidelines) @@ -41,6 +42,12 @@ To open your own pull request, click [here](https://github.com/Azure/LinuxPatchE ### Pull Request Guidelines +#### PR Planning / AzGPS Engineering Requirements + +The backlog for the Linux Patch Extension is tracked internally at Microsoft (by the Azure Guest Patching Service team in the Azure Core Compute Platform). There are also closed-source dependencies with the Compute Platform on this extension, and there are internal quality-control requirements set on end-to-end scenarios. + +To ensure smooth engineering, if there's a change required on the extension, please proactively start a conversation with the engineering team via the Issues page. We cannot provide an SLA on unsolicited PRs if not discussed prior, so please reach out as early as possible. + #### Cleaning up Commits If you are thinking about making a large change, **break up the change into small, logical, testable chunks, and organize your pull requests accordingly**. @@ -51,28 +58,49 @@ If you find yourself creating a pull request and are unable to see all the chang If splitting up the pull request is not an option, we recommend **creating individual commits for different parts of the pull request, which can be reviewed individually on GitHub**. -For more information on cleaning up the commits in a pull request, such as how to rebase, squash, and cherry-pick, click [here](https://github.com/Azure/azure-powershell/blob/dev/documentation/development-docs/cleaning-up-commits.md). +For more information on cleaning up the commits in a pull request, such as how to rebase, squash, and cherry-pick, click [here](https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/cleaning-up-commits.md). #### General guidelines The following guidelines must be followed in **EVERY** pull request that is opened. -- Title of the pull request is clear and informative -- There are a small number of commits that each have an informative message -- A description of the changes the pull request makes is included, and a reference to the issue being resolved, if the change address any -- All files have the Microsoft copyright header +- Title of the pull request is clear and informative. +- There are a small number of commits that each have an informative message. +- A description of the changes the pull request makes is included, and a reference to the issue being resolved, if the change address any. +- All files have the Microsoft copyright header. #### Testing Guidelines The following guidelines must be followed in **EVERY** pull request that is opened. - Pull request includes test coverage for the included changes -- All existing tests must continue to pass successfully on both Python 2.7+ and Python 3.x. -- Code must have been tested on all supported distributions and versions of those distributions that have not reached end of life. The distribution test matrix is as follows: + - All new code introduced **must not** reduce the measured code coverage of any file or of the master branch as a whole. + - Code coverage threshold to be met: **95% on all new code.** Efforts are ongoing to meet or exceed this target on existing code. +- All existing tests must continue to pass successfully on both Python 2.7+ and Python 3.x (latest version). +- Code must have been tested on all supported distributions and versions of those distributions that have not reached end of life. The primary distribution test matrix is as follows: Dist | Version | -----|---------| -Ubuntu Server | 16.04-LTS, 18.04-LTS, 20.04-LTS -Red Hat Enterprise Linux | 6 (x86/x64), 7 (x64), 8 (x64) -CentOS | 6 (x86/x64), 7 (x64), 8 (x64) -SUSE Linux Enterprise Server | 11 (x86/x64), 12 (x64), 15 (x64) +Ubuntu Server | 20.04-LTS, 22.04-LTS, 24.04-LTS +Red Hat Enterprise Linux | 8 (x64), 9 (x64) +SUSE Linux Enterprise Server | 15 (x64) + +The following distribution-versions are supported under **extended support policies** from the vendor and **must also be tested**: + +Dist | Version | Comment | +-----|---------|---------| +Ubuntu Server | 16.04-LTS, 18.04-LTS | Until Apr 2nd, 2026 & Apr 1st, 2028 (resp.) +Red Hat Enterprise Linux | 7 (x64) | Until Jun 30th, 2024 +CentOS | 7 (x64) | Until Jun 30th, 2024 +SUSE Linux Enterprise Server | 12 (x64) | Until Oct 31st, 2027 + +The following distributions have been **EXCLUDED** from support due to end of life and end of extended support: + +Dist | Version | Comment | +-----|---------|---------| +Red Hat Enterprise Linux | 6 (x86/x64) | Ended Nov 30th, 2020 +CentOS | 6 (x86/x64), 8 (x64) | Ended Nov 30th, 2020 & Dec 31st, 2021 (resp.) +SUSE Linux Enterprise Server | 11 (x86/x64) | Ended Mar 31st, 2022 + +**All dates listed are accurate as of March 12th, 2024. Please refer to official distribution vendor guidance for up-to-date information.** + From ac711be885b5e5ccfb446f93c01d1a57a118429c Mon Sep 17 00:00:00 2001 From: Koshy John Date: Tue, 5 Nov 2024 13:43:12 -0800 Subject: [PATCH 6/7] Trying exclusion per docs --- codecov.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 00000000..3edf4c2b --- /dev/null +++ b/codecov.yml @@ -0,0 +1,2 @@ +ignore: + - "distro.py" \ No newline at end of file From 3d736fbefffee0b3b390541a97b3fb286f6ee543 Mon Sep 17 00:00:00 2001 From: Koshy John Date: Tue, 5 Nov 2024 13:50:08 -0800 Subject: [PATCH 7/7] Trying this another way --- .github/codecov.yml | 3 ++- codecov.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/codecov.yml b/.github/codecov.yml index e389f431..3c17c5f3 100644 --- a/.github/codecov.yml +++ b/.github/codecov.yml @@ -5,7 +5,8 @@ comment: github_checks: annotations: false ignore: - - "distro.py" + - "**/distro.py" + - "src/external_dependencies" coverage: precision: 2 round: down diff --git a/codecov.yml b/codecov.yml index 3edf4c2b..82777754 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,2 +1,3 @@ ignore: - - "distro.py" \ No newline at end of file + - "**/distro.py" + - "src/external_dependencies" \ No newline at end of file