-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Linking example needs to be updated to use alternativeSecurityId #50
Comments
I've added these for others who have hit the same issues as me. |
I've tried to make changes in sample files accordingly to your suggestions with no success. Is it possible to have further information about all the replacements that you must do? |
We have this working in a production system. My concern is that no one from MS seems to have looked at or commented on this issue. Which part is failing? Have you enabled development mode / logging to application insights to your policy? You can couple this with the wingtip journey player, which can be found on the net, to help figure out at what point your custom policy is failing |
@filipemiguelaugusto looks like the docs reflect However, this sample still needs to be updated. |
@iamkoch my problems starts way back. It seems like i can't get the right transformations in the files to upload them without errors. I'm far from being an expert in this kind of customizations! I get errors like this one for instance: I tried to follow the changes that you have purposed but i keep get this kind of errors. |
Take the XML from my original post and include it in yours. It contains the replacement transformations used to manipulate alternative security id based claims |
@filipemiguelaugusto From the error message, it looks like you might be mixing UserIdentity claims transformation with AlternativeSecurityId DataType. If you can post an example of your policy, I can help you identity the issue. |
@iamkoch Sorry for late response. Both UserIdentities and AlternativeSecurityId solution should work. If UserIdentities do not, may I know where you find it outdated or not working so I may look into it? Thanks! |
Hi @xinaxu Below is the particular log from app insights. The line of interest is The documentation states that the transformations return JSON as a string, however, the user identity path seems to return an instance of a useridentity. I have redacted tenant and user-specific data.
|
@xinaxu plz find attached my policy file with some changes as suggested at this post. |
@iamkoch Could you try adding below to the metadata of that technical profile. |
@filipemiguelaugusto Looks like you have commented out
|
@xinaxu Adding that key worked for me. I added to both the AAD-Common and AAD-UserReadUsingObjectId technical profiles. For whatever reason, I had ApiVersion instead of api-version as the key. This should be updated in msft docs and I could find the places where that is the case |
@seantleonard I see your confusion. We will update the samples. |
@xinaxu Adding that key worked for me also. I replaced it everywhere i had ApiVersion to api-version. Thanks for the help provided. |
Hi, as of today should we use userIdentities or alternativeSecurityIds ? |
It seems that the account linking example is now out of date. It refers to the
userIdentities
claim being of typeuserIdentityCollection
, which it is now not. Instead, any reference toUserIdentity
andUserIdentityCollection
are nowAlternativeSecurityId
andAlternativeSecurityIdCollection
. This change seems to be spread across a few different docs, i.e. how to link is in this repo, but how to usealternativeSecurityId
with respect to linking and claim transformations is found elsewhereIf I have time to change these samples and test them, which is unlikely, then I will. Otherwise, for those who need to know what to do, I'll outline the steps below.
I have had to refactor the account linking example to use, in all policies that reference them. the following:
identityProvider
in place ofissuer
alternativeSecurityId
in place ofuserIdentity
alternativeSecurityIdCollection
in place ofuserIdentityCollection
alternativeSecurityIds
in place ofuserIdentities
Also, the transformations that relate to modifying and creating
userIdentity
now need to refer toalternativeSecurityId
, as follows:The text was updated successfully, but these errors were encountered: