Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importer/Inserter return values #5

Open
nmoinvaz opened this issue Apr 20, 2018 · 0 comments
Open

Importer/Inserter return values #5

nmoinvaz opened this issue Apr 20, 2018 · 0 comments

Comments

@nmoinvaz
Copy link
Contributor

nmoinvaz commented Apr 20, 2018 •
edited
Loading

I don't believe that $ticketId in insertTicket will ever be WP_Error because wp_insert_post's second argument $wp_error is false.

importer/src/Importer/Inserter.php

Line 135 in 40de7e0

$ticketId = wpas_insert_ticket([

This will require a fix to wpas_insert_ticket which is part of Awesome Support plugin (not the importer).

The same goes for $response in insertHistoryItem, it is missing the second argument $wp_error which should be true:

importer/src/Importer/Inserter.php

Line 270 in 40de7e0

$response = wp_update_post([

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmoinvaz