Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic cleanup of invalid WRs in Game Search tool #147

Open
Avasam opened this issue Aug 31, 2020 · 2 comments
Open

Automatic cleanup of invalid WRs in Game Search tool #147

Avasam opened this issue Aug 31, 2020 · 2 comments

Comments

@Avasam
Copy link
Owner

Avasam commented Aug 31, 2020

If a WR run is sudennly worth 0 points, there is currently no good way to remove it from the game search.

It can happen for a variety of reasons listed under step 1 in the readme. For some of them we have obtained the leaderboard data. If it's WR and worth 0 I can just request the DB for deletion (it shouldn't hit the DB too much I think).

However it's not as simple when we discarded a run early, such as when it falls under 1m.

@shenef
Copy link
Contributor

shenef commented Sep 1, 2020

Is that to improve performance and lessen the load on the srcom api?
There are a lot of highly contested IL's that are shorter than 1 minute and that change would cause IL hunters to lose a majority of their points.

@Avasam
Copy link
Owner Author

Avasam commented Sep 4, 2020

@shenef This issue/suggestion is just for the game search tool I'm working on (semi public, if you're logged in you'll see it at: https://www.avasam.dev/global-scoreboard/game-search ). Which already doesn't include ILs.

Full game runs under a minute are excluded yes, to improve performance and lessen the load on SRC, as you said. (see the last point of step 1 in the Readme.md)
ILs are affected differently, since they're already worth a fraction of a run ("the quantity of ILs for the game + 1", ie if there's 5 ILs, it's worth 1/6). I've decided the the minimum time should follow the same rule: 1/6h of 1 minute -> 10s). So only runs that are way, way too short are afftected. (see step 8)

@Avasam Avasam changed the title Automatic cleanup of runs under 1 minute Automatic cleanup of invalid WRs in Game Search tool Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants