Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate_Combobox #287

Merged
merged 6 commits into from
Sep 2, 2023
Merged

Migrate_Combobox #287

merged 6 commits into from
Sep 2, 2023

Conversation

JanTamis
Copy link
Collaborator

@JanTamis JanTamis commented Sep 1, 2023

@JanTamis JanTamis self-assigned this Sep 1, 2023
@SKProCH
Copy link
Collaborator

SKProCH commented Sep 1, 2023

I have some drafts for ComboBoxes. I'll push it to this branch, but feel free to change everything, since not everything works properly

@JanTamis
Copy link
Collaborator Author

JanTamis commented Sep 1, 2023

Ill take a look

@JanTamis
Copy link
Collaborator Author

JanTamis commented Sep 1, 2023

I have some drafts for ComboBoxes. I'll push it to this branch, but feel free to change everything, since not everything works properly

can you tell me what doesn't work?

@SKProCH
Copy link
Collaborator

SKProCH commented Sep 1, 2023

Triangle missing in the default style. Also, seems like the outline style has incorrect clipping for frame/border (proper variant implemented in TextBox outlines style). Probably some watermark/label problems.

@JanTamis
Copy link
Collaborator Author

JanTamis commented Sep 1, 2023

Triangle missing in the default style. Also, seems like the outline style has incorrect clipping for frame/border (proper variant implemented in TextBox outlines style). Probably some watermark/label problems.

@SKProCH Can you check if the bugs are resolved?

@SKProCH
Copy link
Collaborator

SKProCH commented Sep 1, 2023

Triangle missing in the default style. Also, seems like the outline style has incorrect clipping for frame/border (proper variant implemented in TextBox outlines style). Probably some watermark/label problems.

@SKProCH Can you check if the bugs are resolved?

Yep, a little later

@SKProCH
Copy link
Collaborator

SKProCH commented Sep 1, 2023

Probably default combobox too tall - even compared with Filled. Everything else is fine

@JanTamis
Copy link
Collaborator Author

JanTamis commented Sep 1, 2023

Probably default combobox too tall - even compared with Filled. Everything else is fine

How tall would you like it to be?

@SKProCH
Copy link
Collaborator

SKProCH commented Sep 1, 2023

Probably default combobox too tall - even compared with Filled. Everything else is fine

How tall would you like it to be?

Probably same size of textbox i suppose. But feel free to choose yourself - it's just my opinion.

@JanTamis
Copy link
Collaborator Author

JanTamis commented Sep 1, 2023

image Is this okay? (from 56 to 48 px)

@SKProCH
Copy link
Collaborator

SKProCH commented Sep 1, 2023

Yep. Thanks! Should we merge this?
Seems like there is #269, but i think what we can resolve it after 3.0.0 release.

@JanTamis
Copy link
Collaborator Author

JanTamis commented Sep 2, 2023

Ill take a short look if I can resolve it.

@JanTamis
Copy link
Collaborator Author

JanTamis commented Sep 2, 2023

so I taken a look but I couldn't figure it out, so it can be merged.

@JanTamis JanTamis marked this pull request as ready for review September 2, 2023 11:44
@SKProCH SKProCH merged commit e514e98 into master Sep 2, 2023
@SKProCH SKProCH deleted the Migrate_Combobox branch January 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants