Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CoreSelector UI #2232

Open
1 of 4 tasks
FabienLelaquais opened this issue Nov 10, 2024 · 1 comment
Open
1 of 4 tasks

Improve CoreSelector UI #2232

FabienLelaquais opened this issue Nov 10, 2024 · 1 comment
Assignees
Labels
GUI: Front-End 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general 🥶Waiting for contributor Issues or PRs waiting for a long time

Comments

@FabienLelaquais
Copy link
Member

Description

Problem

The generic selector (used in scenario_selector and data_node_selector) is slightly off in terms of UI concerns:

  • The title of the property name to filter/sort on is 'Column' which is confusing
  • If there is only a single property to filter/sort on, it should be selected by default (and probable to be a selector in the first place)
  • The wording for the test is a bit off.
    • string: 'not equals' is unproper.
    • boolean: 'equals' are 'not equals' could better be 'is' and 'is not'
    • date: 'before' and 'after' are not verbs, contrary to 'equals', which is.
    • number has similar problems
  • The "Empty string" default value for the last field is confusing (even worse when selecting it, as it become the field label).
    This might be simply 'Value'.

Proposal

This proposal impacts both the TableFilter and TableSort components.

  • Augment the TableFilter and TableSort APIs to provide the 'Column' label.
    This would be 'Property' when used by the Core Visual Elements.
  • The 'Action' label would be better called "Condition"
  • The operators would be better worded:
    • string: is, is not, contains, does not contain, starts with, end with...
    • Boolean: is, is not (better would have been "is true" and "is false" but that would break the homogeneity)
    • date: is on, is before, is after, is on or before, is on or after
    • number: is, is not, is greater than, is less than, is greater than or equal to, is less than or equal to
  • Tooltips should be provided where relevant:
    • "Column" selector: "Select the table column you want to filter/sort on"/"Select the property name you want to filter/sort on"
    • "Action" selector: "Select the condition to apply to the selected column/property"
    • "Value": "Enter the value you want to filter/sort by"
  • "Empty string" become "Value"

Acceptance Criteria

  • Any new code is covered by a unit tested.
  • Check code coverage is at least 90%.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@FabienLelaquais FabienLelaquais added 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed GUI: Front-End 📝Release Notes Impacts the Release Notes or the Documentation in general labels Nov 10, 2024
@FabienLelaquais FabienLelaquais self-assigned this Nov 12, 2024
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general 🥶Waiting for contributor Issues or PRs waiting for a long time
Projects
None yet
Development

No branches or pull requests

1 participant