Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social | Make resharing async in classic editor #40302

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Social | Make resharing async in classic editor #40302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66d8a71
Social | Make resharing async in classic editor
manzoorwanijk Nov 22, 2024
e4bd02d
Update messaging
manzoorwanijk Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...kages/publicize-components/changelog/update-social-make-resharing-async-in-classic-editor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Social | Updated messaging for async sharing in block editor
2 changes: 1 addition & 1 deletion projects/js-packages/publicize-components/src/components/share-post/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function showErrorNotice( message = __( 'Unable to share the Post', 'jetpack' )
*/
function showSuccessNotice() {
const { createSuccessNotice } = dispatch( noticesStore );
createSuccessNotice( __( 'Your post will be shared soon.', 'jetpack' ), {
createSuccessNotice( __( 'Request submitted successfully.', 'jetpack' ), {
id: 'publicize-post-share-message',
type: 'snackbar',
} );
Expand Down
4 changes: 4 additions & 0 deletions projects/packages/publicize/changelog/update-social-make-resharing-async-in-classic-editor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Social | Made resharing async in classic editor to fix timeout issues
5 changes: 5 additions & 0 deletions projects/packages/publicize/src/class-rest-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ public function register_rest_routes() {
return array_map( 'absint', $param );
},
),
'async' => array(
'description' => __( 'Whether to share the post asynchronously.', 'jetpack-publicize-pkg' ),
'type' => 'boolean',
'default' => false,
),
),
)
);
Expand Down
3 changes: 2 additions & 1 deletion projects/packages/publicize/src/js/classic-editor-connections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,11 @@ jQuery( function ( $ ) {
data: {
message,
skipped_connections,
async: true,
},
} )
.then( () => {
showNotice( __( 'Your post has been shared!', 'jetpack-publicize-pkg' ), 'success' );
showNotice( __( 'Request submitted successfully.', 'jetpack-publicize-pkg' ), 'success' );
} )
.catch( () => {
showNotice( __( 'An error occurred while sharing your post.', 'jetpack-publicize-pkg' ) );
Expand Down
5 changes: 5 additions & 0 deletions ...nc/lib/core-api/wpcom-endpoints/class-wpcom-rest-api-v2-endpoint-publicize-share-post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ public function register_routes() {
return array_map( 'absint', $param );
},
),
'async' => array(
'description' => __( 'Whether to share the post asynchronously.', 'jetpack' ),
'type' => 'boolean',
'default' => false,
),
),
),
// override = true because this API route was commandeered from the file
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-social-make-resharing-async-in-classic-editor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Social | Made resharing async in classic editor to fix timeout issues
Loading