Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix subscribe block #40300

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+5 −0
Open

WIP: fix subscribe block #40300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa636f4
set width to auto
lezama Nov 22, 2024
91d584a
changelog
lezama Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-subscribe-block
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

fixes something in wpcom
1 change: 1 addition & 0 deletions projects/plugins/jetpack/extensions/blocks/subscriptions/view.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
// Prevent white-space issues on Firefox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to move the comment above white-space now

.wp-block-jetpack-subscriptions__button[contenteditable="true"] {
white-space: pre-wrap !important;
width: auto !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can add CSS specificity instead of these !importants

}

input[type="email"]::placeholder,
Expand Down
Loading