Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Previews: Decode entities in post titles, excerpts, and descriptions #40256

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Social Previews: Decode entities in post titles, excerpts, and descriptions #40256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f71aee
Decode entities in social previews
sixhours Nov 19, 2024
7c03aa0
changelog
sixhours Nov 19, 2024
2b6eae7
Decode entities in excerpts as well
sixhours Nov 21, 2024
637b99a
Update modal.js
manzoorwanijk Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/js-packages/publicize-components/changelog/fix-decode-entitles-title
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Decode entities in post titles and descriptions for social previews.
7 changes: 4 additions & 3 deletions projects/js-packages/publicize-components/src/components/social-previews/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

import { Button, Modal, TabPanel } from '@wordpress/components';
import { decodeEntities } from '@wordpress/html-entities';
import { __ } from '@wordpress/i18n';
import { close } from '@wordpress/icons';
import { useAvailableSerivces } from './use-available-services';
Expand Down Expand Up @@ -36,9 +37,9 @@ const SocialPreviewsModal = function SocialPreviewsModal( { onClose, initialTabN
<div>
<tab.preview
// pass only the props that are common to all previews
excerpt={ excerpt }
title={ title }
description={ description }
excerpt={ decodeEntities( excerpt ) }
title={ decodeEntities( title ) }
description={ decodeEntities( description ) }
url={ url }
image={ image }
media={ media }
Expand Down
Loading