-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoPress: play button remains visible on top of video after exiting full screen #9602
Comments
The player should look the same on mobile as it does on desktop. Have you experienced issues with the player in the past? If so, could you post a link to a page where you've seen some issues, and let us know what device and browser you used? Screenshots can also be helpful. Thank you. |
I can't seem to be able to reproduce this. Could you make a screenshot of what you see on your end?
This is tracked here: #8092
This is tracked here: #9603
Could you share a screenshot of what you see for this as well? Thank you! |
Thank you. Since all issues but the Firefox one are tracked elsewhere, I'll edit the description of this issue to track the issues you're having in Firefox. |
Could you let us know what version of Firefox Mobile you are currently using? |
the firefox version is 60.0.1 |
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
@jeherve I can confirm this behavior in Chrome as well. Steps to Reproduce
Expected Result Video plays normally. Actual Result Video continues playing, but with play button and title floating on top. Via 1891382-zen |
@jeherve regarding the above issue (with 1891382-zen), the version of Chrome in question is 73.0. Would you have any insight on what could be causing this? |
I don't know yet, but I'll edit the description to mention that it is now happening in more browsers. :( |
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
Bumping as we received a request for an update in 2422573-zen about this issue. Letting them know no movement yet. |
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
Another report in 3194751-zen ( WordPress.com simple site) Also confirmed myself in Firefox on Android. |
3588222-zen |
I don't know why this is not resolved yet! |
8479524-zen I was able to reproduce in Safari and Chrome on iOS. |
Support References This comment is automatically generated. Please do not edit it.
|
The issue where the Play/Pause button keeps staying on top of all layers after opening the menu to choose parameters such as Video Quality and Speed keeps occurring in different browsers on mobile devices, such as Chrome and Safari. In the past we have had constant communication with the support team with suggestions for improvement for Videopress. In this case, Jetpack/Videopress support has recommended that we post in this thread to get it directly to the development team. As we are interested in providing the best player quality to our users, we have been looking for options to help fix this issue with the Play button. Please consider the following CSS codes as a suggestion to check and confirm if it works, and let us know the results.
We hope these suggestions are helpful, please let us know. |
The following fix was incorporated and deployed. Thanks for the involvment and the contribution! 🙌
We are still liaising whether we will incorporate the rest of the suggested styling improvements. |
First of all thank you for providing the suggested code fix. This is very appreciated! 🙇 Now, regarding the actual height of the progress bar, I have a little more background. The tall bar on mobile is designed to make it easier to tap with your thumb. If it’s too small, it becomes difficult to use reliably. Currently, it’s 32px tall, which is already below the recommended 44px for mobile touch targets. Reducing it further could create usability problems. Therefore we made the call not reduce the height of the bar on mobile. I hope our reasoning is understandable. |
Once again, we greatly appreciate your suggestion and have given it consideration. However, as VideoPress feature development is not a high priority at the moment, implementing the change would require coordination with multiple teams (design, development) and a review of other player UI components to ensure consistency. Despite the simplicity of the code change, we have decided not to pursue this suggestion at this time. |
Now, that the issues reported in the #9602 (comment) are addressed I am proceeding to close the issue. |
Currently VideoPress looks great on computer browsers. Please ensure that it has the same skin on mobile platforms as it is on the desktop browsers. It should also be tested to work perfectly well on these devices
The text was updated successfully, but these errors were encountered: