Skip to content

Commit

Permalink
Merge pull request PrestaShop#1025 from M0rgan01/improve-check-requir…
Browse files Browse the repository at this point in the history
…ements-command

[CLI] Improve "update:check-requirements" command
  • Loading branch information
M0rgan01 authored Dec 3, 2024
2 parents 163a102 + 7505134 commit ef62f4b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
14 changes: 14 additions & 0 deletions classes/Commands/CheckRequirementsCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
use Exception;
use PrestaShop\Module\AutoUpgrade\Exceptions\DistributionApiException;
use PrestaShop\Module\AutoUpgrade\Exceptions\UpgradeException;
use PrestaShop\Module\AutoUpgrade\Parameters\UpgradeConfiguration;
use PrestaShop\Module\AutoUpgrade\Services\DistributionApiService;
use PrestaShop\Module\AutoUpgrade\Services\PhpVersionResolverService;
use PrestaShop\Module\AutoUpgrade\Task\ExitCode;
Expand Down Expand Up @@ -58,6 +59,8 @@ protected function configure(): void
->setDescription('Check all prerequisites for an update.')
->setHelp('This command allows you to check the prerequisites necessary for the proper functioning of an update.')
->addOption('config-file-path', null, InputOption::VALUE_REQUIRED, 'Configuration file location for update.')
->addOption('zip', null, InputOption::VALUE_REQUIRED, 'Sets the archive zip file for a local update.')
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.')
->addArgument('admin-dir', InputArgument::REQUIRED, 'The admin directory name.');
}

Expand All @@ -70,6 +73,17 @@ protected function execute(InputInterface $input, OutputInterface $output): ?int
$this->setupEnvironment($input, $output);
$this->output = $output;

$options = [
UpgradeConfiguration::ARCHIVE_ZIP => 'zip',
UpgradeConfiguration::ARCHIVE_XML => 'xml',
];
foreach ($options as $configKey => $optionName) {
$optionValue = $input->getOption($optionName);
if ($optionValue !== null) {
$this->consoleInputConfiguration[$configKey] = $optionValue;
}
}

$configPath = $input->getOption('config-file-path');
$exitCode = $this->loadConfiguration($configPath);
if ($exitCode !== ExitCode::SUCCESS) {
Expand Down
6 changes: 6 additions & 0 deletions classes/Task/Miscellaneous/UpdateConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ public function run(): int
}
}

// If no channel is specified, and there is a configuration relating to archive files, we deduce that the channel is local
$archiveFilesConfExist = isset($config[UpgradeConfiguration::ARCHIVE_XML]) || isset($config[UpgradeConfiguration::ARCHIVE_ZIP]);
if (!isset($config[UpgradeConfiguration::CHANNEL]) && $archiveFilesConfExist) {
$config[UpgradeConfiguration::CHANNEL] = UpgradeConfiguration::CHANNEL_LOCAL;
}

$isLocal = $config[UpgradeConfiguration::CHANNEL] === UpgradeConfiguration::CHANNEL_LOCAL;

$error = $this->container->getConfigurationValidator()->validate($config);
Expand Down

0 comments on commit ef62f4b

Please sign in to comment.