Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_hp_centroid instead of all_hp_centroid_tpower in Timbral_Brightness.py #9

Open
giampierosalvi opened this issue Oct 4, 2018 · 1 comment

Comments

@giampierosalvi
Copy link

Hi,
if I read the code in Timbral_Brightness.py correctly, line 125 should say:
all_hp_centroid_tpower.append(hp_centroid_tpower)
and line 132 should say:
weighted_mean_hp_centroid = np.average(all_hp_centroid, weights=all_hp_centroid_tpower)

Otherwise the hp_centroid array would contain a mixture of centroid frequencies and powers, and the average in line 129 and 132 would not make too much sense.

Is this correct? Can you fix it?
Thank you!
Giampiero and Jérôme

@AndyP103
Copy link
Collaborator

AndyP103 commented Oct 4, 2018

Thank you for noticing this.
Yes, you are correct that line lines were mistakes. However, due to the nature of the regression algorithm used, this did not have a large impact on the resulting predicted brightness.

I've changed these lines as you suggested.

Andy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants