The "Field to Perform Lookup With" Setting Does Not Work

[AustinTSchaffer]

The "Field to Perform Lookup With" setting does not work as expected.

The setting has a default value of "{default}". If the setting is set to this value, the code will extract the field description from DataMapping.BarcodeFieldMapping, which it will later use when to provide barcodes to the Alma API. If the value of the setting is changed, the code will not extract any field description, so it will not be able to provide barcodes to the Alma API.

AlmaBarcodeLookup/Main.lua

Line 46 in 29ac212

if settings.FieldToPerformLookupWith:lower() == "{default}" then

Either (a) the setting should be removed or (b) the code should allow for non-default field descriptions within that setting. For either case, we should review the README to be sure that the program flow is clear. For case (b), this would look something like the following:

-- Find the field to perform lookup with
if settings.FieldToPerformLookupWith:lower() == "{default}" then
  settings.FieldToPerformLookupWith = DataMapping.BarcodeFieldMapping[product];
end

settings.FieldToPerformLookupWith = Utility.StringSplit(".", settings.FieldToPerformLookupWith);
settings.FieldToPerformLookupWith[1] = Utility.Trim(settings.FieldToPerformLookupWith[1]);
settings.FieldToPerformLookupWith[2] = Utility.Trim(settings.FieldToPerformLookupWith[2]);
log:InfoFormat("Field to Perform Lookup With is {0}.{1}", settings.FieldToPerformLookupWith[1], settings.FieldToPerformLookupWith[2]);