Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction support #32

Open
javiercornejo opened this issue Nov 24, 2017 · 3 comments
Open

Transaction support #32

javiercornejo opened this issue Nov 24, 2017 · 3 comments

Comments

@javiercornejo
Copy link

Hi there.
First I want to thank you for this project.
I read in the documentation that offshore-sql does not have Transaction support yet bu I saw in the code some reference to commit / rollback functions. So my questions is: Do you know some way to use transaction with oracledb with this version of the project?
Thank you in advance.
Regards.

@atiertant
Copy link
Contributor

@javiercornejo you 're right, you can use transaction with offshore, see https://github.com/Atlantis-Software/offshore-docs/blob/master/transaction/transactions.md

@javiercornejo
Copy link
Author

Hi @atiertant thank you for your response!! I figured out few days earlier than your response. It works very good and thank you for implementing it.

I noticed that when I create / query some instance and then I access to some standard Class Method like .save() or .remove() is not executed in the transaction that created / retrieve the instance in first place. Do you think this is possible to implement?

Regards and thanks again!

@atiertant
Copy link
Contributor

for sure, there are maybe some missing _loadQuery in this functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants