Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a simple info log for delete instance id disabled #17

Open
1 task
mlajkim opened this issue Jun 12, 2023 · 0 comments
Open
1 task

Write a simple info log for delete instance id disabled #17

mlajkim opened this issue Jun 12, 2023 · 0 comments
Labels
logging Changes in logger

Comments

@mlajkim
Copy link
Contributor

mlajkim commented Jun 12, 2023

https://github.com/AthenZ/k8s-athenz-sia/blob/main/pkg/identity/certificated.go#LL262C1-L262C1

Would be great to have a info log when delete instance id feature is disabled, so that the operation check of the k8s could be easier to be understood by those who are not familiar with k8s yet.

TODOs

  • think of a good idea not to create more logs, but still handles.
    • Maybe with Shutting down ... you can put Shutting down with delete_instance_id disabled ... could be an option.
@mlajkim mlajkim added the logging Changes in logger label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging Changes in logger
Projects
None yet
Development

No branches or pull requests

1 participant