Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup mechanism for renamed countries e.g. Swaziland #275

Open
sandy-fairsupply opened this issue Nov 16, 2023 · 5 comments
Open

Lookup mechanism for renamed countries e.g. Swaziland #275

sandy-fairsupply opened this issue Nov 16, 2023 · 5 comments

Comments

@sandy-fairsupply
Copy link

Countries change names from time to time. For example, Swaziland changed its name to Eswatini in 2018, but kept their country code (SWZ). "Swaziland" doesn't appear in countries or former_countries, so it's not possible to look up the country code based on old data without a separate look-up table.

It would be nice to have a mechanism for looking up countries by their former names.

@Atem18
Copy link
Owner

Atem18 commented Nov 16, 2023

Hi,

thanks for the bug report, I will check how to do that.

@Atem18
Copy link
Owner

Atem18 commented Nov 16, 2023

@sandy-fairsupply Since "Swaziland" does not appear in countries or former_countries but still is translations, this looks like a bug. Can you file one in the upstream repo : https://salsa.debian.org/iso-codes-team/iso-codes ?

@sandy-fairsupply
Copy link
Author

sandy-fairsupply commented Nov 19, 2023

I would, but I don't have a Salsa account which is a bit of a barrier for me. Also, I think I lack the experience in this domain to make a good report. Would you mind doing it?

Relevant documents:

Curiously, it doesn't seem to be in ISO 3166-3 (although I don't have access to the official document). Maybe that's because it was just renamed, not dissolved.

I suspect the only way to deal with this kind of issue would be to consume the updates (like the one I linked to above), rather than exclusively importing the codes in bulk.

@Atem18
Copy link
Owner

Atem18 commented Nov 19, 2023

This library is intended to allow easy access to the debian upstream files so if there is any issue, it should be reported there.

I will make a bug report and see what they are saying.

@Atem18
Copy link
Owner

Atem18 commented Nov 23, 2023

@sandy-fairsupply Bur report created : https://salsa.debian.org/iso-codes-team/iso-codes/-/issues/46

Let's see what they will say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants