Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finding largest closed contour for PDFs #155

Open
3 tasks
e-koch opened this issue Jul 11, 2017 · 3 comments
Open
3 tasks

Add finding largest closed contour for PDFs #155

e-koch opened this issue Jul 11, 2017 · 3 comments

Comments

@e-koch
Copy link
Member

e-koch commented Jul 11, 2017

  • Find largest closed contour for given map
  • Allow passing a custom mask to get PDFs of sub-regions
  • Add to tutorial page and describe how custom masking should be done (e.g., with spectral-cube)
@keflavich
Copy link
Contributor

This has to be built into the contour finding algorithms already, right? They must be making a choice somewhere about whether or not to draw a line, and at map edges, that choice is 'no'. So it should hopefully be easy to find.

@low-sky
Copy link
Contributor

low-sky commented Jul 11, 2017 via email

@e-koch
Copy link
Member Author

e-koch commented Jul 11, 2017

I think so. We're already using some of the mpl contour backend for PCA: https://github.com/Astroua/TurbuStat/blob/master/turbustat/statistics/pca/width_estimate.py#L153. Maybe starting the search at the maximum along the edge would be efficient. Though there should be some minimum size requirement for the region along the edge too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants