Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[METIS] [other instruments] missing functionality in Scopesim #136

Open
oczoske opened this issue Sep 13, 2023 · 0 comments
Open

[METIS] [other instruments] missing functionality in Scopesim #136

oczoske opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request instrument-specific Limited to a certain IRDB instrument package

Comments

@oczoske
Copy link
Collaborator

oczoske commented Sep 13, 2023

Action item from the weekly A*/METIS videocon, 13 September 2023, following a request from the METIS project office for a development schedule for the "fully finished" simulator.
These are some issues that ought to be implemented before Scopesim can be considered a fully functional simulator for METIS (and other instruments). I include some very vague ideas for implementation, which may or may not work.

  • Sequences of exposures: Observing blocks for METIS typically involve sequences of exposures (dithered LM images, chop-nodded N images, LMS dithered and rotated exposures,...). These sequences need to take into account either field rotation or pupil (PSF) rotation from one exposure to the next. In principle this can always be done using scripts that modify sources and parameters, effectively creating each exposure with an independent Scopesim simulation; however, this requires a lot of effort from the user.

    • implement field rotation and field shift through Scopesim parameters, maybe effective when creating the FieldOfView object from the Source
    • implement PSF rotation, probably as part of the PSF effects
    • implement a wrapper (replacement or extension of OpticalTrain.observe()?) that runs a sequence of observations with the necessary parameter changes from one exposure to the next.
  • Differential atmospheric refraction: Some work has been done, but I don't think this is fully functional yet. The effect should take a DAR model as input, which can be the full atmospheric effect or the residuals from METIS' fixed ADCs.

  • LMS (nominal) is nearly finished, except for an unsolved issue connected to the FieldOfView (TestObserveSpectroscopyMode::test_runs in test_basic_instrument.py fails). Should be tested for flux throughput.

  • LMS (extended) is missing. Can only be implemented once spectral mapping model is available from UK/ATC. The complexity of the implementation depends on the format of that model.

@teutoburg teutoburg added enhancement New feature or request instrument-specific Limited to a certain IRDB instrument package labels Nov 9, 2023
@teutoburg teutoburg moved this from 🆕 New to 📋 Backlog in ScopeSim-development Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request instrument-specific Limited to a certain IRDB instrument package
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants