Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIX MvA : WCS calibrations in IMG-N data products #251

Closed
astronomyk opened this issue Oct 23, 2023 · 6 comments
Closed

RIX MvA : WCS calibrations in IMG-N data products #251

astronomyk opened this issue Oct 23, 2023 · 6 comments
Labels
Milestone

Comments

@astronomyk
Copy link
Contributor

https://jira.eso.org/browse/MET-2082

For METIS-6105 (IMG-N data products): The list of pipeline steps listed here do not include WCS calibrations. Is this also foreseen for N-band imaging data?

@ivh this is a throw back to the PIP Spec Doc. Would you like to comment?

@astronomyk astronomyk added this to the ESO FDR milestone Oct 23, 2023
@ivh
Copy link
Collaborator

ivh commented Oct 23, 2023

@astronomyk I don't understand, why would I know anything about this?

@ivh ivh removed their assignment Oct 23, 2023
@hugobuddel
Copy link
Contributor

This RIX should not exist because it is for the DRLS which is not under review. It will probably not reach the "Submitted" stage. Similar for the other DRLS related ones. If we do get them, then simply answer that the DRLS is not under review. But politely, because we don't want to make it sound like we wasted the reviewers time.

@hugobuddel
Copy link
Contributor

Ah, I understand. This is not about the DRLS, but about the PIP Specification

This is about https://polarion.astron.nl/polarion/#/project/METIS/workitem?id=METIS-6105 "IMG-N data products", which indeed does not list WCS calibration.

The LM-band counterpart https://polarion.astron.nl/polarion/#/project/METIS/workitem?id=METIS-6104 "IMG-LM data products" does list as a last step

world-coordinate system (WCS) based on telescope pointing and derotator position as well as static distortion map

I don't know the procedure for updating the PIP specification, and I don't really care at the moment. So I will answer the question without mentioning we will update the PIP spec.

Answered with

The pipeline for the N-band imaging data does indeed include WCS calibrations.

The relevant recipe is described in the Data Reduction Library Design (E-REP-AST-MET-1006 v1.0), section 6.3.6 "metis_n_img_distortion": "The distortion is described in terms of a polynomial model whose coefficients can be transformed to WCS keywords and applied to any other pipeline product."

@ivh
Copy link
Collaborator

ivh commented Oct 31, 2023

Ah, I also misread this. I can update the item on Polarion.

Edit: ... and I answer Mario's comment in Jira.

@hugobuddel
Copy link
Contributor

Thanks for doing the right thing @ivh and editing the PIP Spec.

In the meantime we confirmed with @Rumpelstil that a) the omission of WCS calibration was deliberate, and b) that decision has been reverted and it should indeed be included. See also #263

I suppose we can now close this, as https://polarion.astron.nl/polarion/#/project/METIS/workitem?id=METIS-6105 has indeed been updated. Or maybe we should first change the status from Draft to Ready for Internal Review?

@ivh
Copy link
Collaborator

ivh commented Nov 1, 2023

Closing this since the AI is already carried out and closed on jira.

@ivh ivh closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants