Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include Response class in default simplate context #402

Closed
chadwhitacre opened this issue Dec 3, 2014 · 3 comments
Closed

include Response class in default simplate context #402

chadwhitacre opened this issue Dec 3, 2014 · 3 comments

Comments

@chadwhitacre
Copy link
Contributor

Suggested by @techtonik at gratipay/gratipay.com@4d7d0dc#commitcomment-8820613. It's definitely a common error, NameError: name 'Response' is not defined. This usually lies along error paths, and error paths are undertested as a rule, so it's a bug that lurks waiting to mask real errors.

@techtonik
Copy link
Contributor

There seems to be response object as well. Might be useful to move Response API there.

And if there is request object, move path API there.

@pjz
Copy link
Contributor

pjz commented Aug 13, 2015

This was done when we moved to passing around all of algorithm state, yes? Oh, wait, no, they're wanting the class, not the default response. Uhh... I don't think we want to do this. We're moving toward being more specific about context imports, not less.

@chadwhitacre
Copy link
Contributor Author

We're moving towards more explicitness with simplate contexts: #30. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants