Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for root configurations #224

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Allow for root configurations #224

wants to merge 14 commits into from

Conversation

nairihar
Copy link

@nairihar nairihar commented Jan 14, 2021

For example we may do this:

const asana = require('node-asana');
asana.config.setConfig('RateLimitEnforced', {
    retry_after: 5000,
});

@nairihar
Copy link
Author

I'm not so sure why we have this kind of error in Travis, but it may be good to have this kind of root configuration. Maybe you can add some comments about how we should fix the tests or how we can implement the same thing another way.

@rossgrambo-zz
Copy link
Contributor

Hmm, I'm not sure what the use case for this change is. For rate_limit_enforced errors, the API sends back a retry-after (which is exactly how long you should wait before your request will succeed) and the client library already parses that for retries.

Is there another error you want config for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants