generators: js: fix sinon dependency to 15.2.0, add node tests #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
changed the title
Williangalvani
force-pushed
the
fix-sinon
branch
from
4684bd8 to
fe9b6f1
Compare
Williangalvani
force-pushed
the
fix-sinon
branch
27 times, most recently
from
12df171 to
862078a
Compare
Williangalvani
force-pushed
the
fix-sinon
branch
from
862078a to
acc7f50
Compare
khancyr
approved these changes
Nov 20, 2023
Williangalvani
force-pushed
the
fix-sinon
branch
from
acc7f50 to
4f85cb0
Compare
Williangalvani
changed the title
peterbarker
approved these changes
Nov 20, 2023
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a node12 issue with optional chaining in Sinon lib. check recent mavlink actions
I'm adding the js tests here because it is weird that it only gets to fail on the other repo.