Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator id issue #138

Open
ryanjAA opened this issue Jan 25, 2024 · 7 comments
Open

Operator id issue #138

ryanjAA opened this issue Jan 25, 2024 · 7 comments

Comments

@ryanjAA
Copy link

ryanjAA commented Jan 25, 2024

In the 1.14 firmware (likely previous ones as well) it requires an operator id otherwise you get the op_id arm error. Since only required in EU jurisdictions some type of mechanism to disable is needed for US based flights. @BluemarkInnovations

@BluemarkInnovations
Copy link
Contributor

@ryanjAA There are two issues at play. PX4 decided (for now) not to implement the OperatorID message. ArduPilot has implemented it and streams empty OperatorID data in the USA. Solution one is that PX4 implements this message type also. In #101 (solution 2) I already suggested to have an region parameter, so you can do checks per region. However, that has not been merged yet in to a stable release.

@ryanjAA
Copy link
Author

ryanjAA commented Jan 26, 2024

What about PX4/PX4-Autopilot#21647 even with this it still is an issue because while op id is transmitted if nothing is populated than it is red on the QGC side (easy to fix) but then on the rid side if something is typed in
we see invalid data said when picking up the module from phone/tablet. I pinged on discord as well. Working on getting this finished on px4

I’m wondering if just omitting op id for FAA based ops. New firmware branch on the rid module side.

@BluemarkInnovations
Copy link
Contributor

Too busy, so I skipped Discord for some months already. So why don't I provide the binaries for PR #101 That should do the trick. That will be next week. Another solution is to change PX4 implementation slightly, so it includes a timestamp in the empty OperatorID message.

See https://github.com/ArduPilot/ArduRemoteID/blob/master/RemoteIDModule/transport.cpp#L63
This line gives the conditions when there is an issue with the Operator ID.

@ryanjAA
Copy link
Author

ryanjAA commented Jan 26, 2024

Notes re discord. Will build this firmware and give it a try but will try your binaries too.

Omitting that line should do the trick.

PX4 side will work to send a timestamp only and ideally localization (so if FAA do that, if EU send xxx). Will pick this up today and come back with findings.

@ryanjAA
Copy link
Author

ryanjAA commented Jan 27, 2024

@BluemarkInnovations is the bluemark fw signed? Or more specifically is lock level >0? I can’t upload newly built ota firmwares.

@BluemarkInnovations
Copy link
Contributor

@ryanjAA See https://github.com/ArduPilot/ArduRemoteID?tab=readme-ov-file#firmware-signing

So basically it is always signed and only allows OTA updates that are signed by the ArduRemoteID dev team keys or from BlueMark. Easiest method is to generate a private signing key yourself. Add the public key to the parameter of the ArdurRemoteID device e.g. to PUBLIC_KEY4. Then sign the OTA firmware with your key, afterwards it will accept your OTA update. Another work around is to flash via UART.

@ryanjAA
Copy link
Author

ryanjAA commented Jan 28, 2024

Noted. Just used uart for the time being but have it working on px4. Will post px4 changes to px4 and QGC and branch this off for the time being.

Also, seeing different responses/messages on different phone apps. Will post that too but that is all on app side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants